Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs, symbolic_solve(single expr, [multiple_vars]), and precompiled nemo #1234

Merged
merged 4 commits into from
Aug 25, 2024

Conversation

n0rbed
Copy link
Member

@n0rbed n0rbed commented Aug 25, 2024

Now symbolic_solve supports expressions such as

symbolic_solve((x - y) * (x - z), [x, y, z])

and similar. Also, added precompile tool hooks (i think they're called that) to nemo.

julia> @time symbolic_solve([x^2 - a^2, x + a], x)
  7.805655 seconds (17.50 M allocations: 1.169 GiB, 2.76% gc time, 99.79% compilation time: <1% of which was recompilation)
1-element Vector{SymbolicUtils.BasicSymbolic{Real}}:
 -a
julia> @time symbolic_solve([x^2 - a^2, x + a], x)
  0.511816 seconds (1.28 M allocations: 85.815 MiB, 3.62% gc time, 98.22% compilation time)
1-element Vector{SymbolicUtils.BasicSymbolic{Real}}:
 -a

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (47cfd60) to head (bf454dc).
Report is 16 commits behind head on master.

Files Patch % Lines
src/solver/main.jl 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1234       +/-   ##
===========================================
+ Coverage    8.30%   79.89%   +71.58%     
===========================================
  Files          46       46               
  Lines        4549     4631       +82     
===========================================
+ Hits          378     3700     +3322     
+ Misses       4171      931     -3240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 7097212 into JuliaSymbolics:master Aug 25, 2024
9 of 11 checks passed
@n0rbed n0rbed deleted the multivar_stuff branch August 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants