Change Scalarization behavior of dot-products, fix issue #459 #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getindex on arrayop
manuelbb-upb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dot-products seem to be handled incorrectly: #459
From my understanding, this is not merely a displaying error:
The old
return Term{S}(*, [A, b])in_matvec(A,B)would become an incorrect SymbolicUtilsMulconstruct whenscalarizeis called.In this fix, I handle dot-products like any matrix-vector product. If
isdot(A,b)==true, I return the indexed result, so that it behaves like a scalar whenwraped.