-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 0.7.1 and add Project.toml #100
Conversation
eafca02
to
c457335
Compare
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 46.96% 54.01% +7.04%
==========================================
Files 7 7
Lines 132 137 +5
==========================================
+ Hits 62 74 +12
+ Misses 70 63 -7
Continue to review full report at Codecov.
|
WebSockets = "104b5d7c-a370-577a-8038-80a2059c5097" | ||
|
||
[compat] | ||
AssetRegistry = "0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these dependencies be opened up a bit more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, although technically only WebSockets can be changed from 1.5
to 1
according to Semver if we want to guarantee non-breakage (because minor releases can have breaking changes while our deps are <1.x
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I meant something like:
HTTP = "0.6, 0.7, 0.8
(Assuming those versions work with the project as well)
2 cents: I don't think I've ever seen |
I think my comment above may have got missed as I submitted it as the thread was being resolved?, link. |
I agree, I think I'm going to drop the last commit and just open up WebSockets to |
f2482ba
to
c8cce80
Compare
Thanks for the help with this! |
No description provided.