Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.7.1 and add Project.toml #100

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Bump to 0.7.1 and add Project.toml #100

merged 3 commits into from
Jan 7, 2020

Conversation

jpsamaroo
Copy link
Collaborator

No description provided.

@jpsamaroo
Copy link
Collaborator Author

@aviks @piever please let me know if these bounds should be something else. Also, do we have JuliaRegistrator and Tagbot setup on the repo?

@codecov-io
Copy link

codecov-io commented Dec 22, 2019

Codecov Report

Merging #100 into master will increase coverage by 7.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   46.96%   54.01%   +7.04%     
==========================================
  Files           7        7              
  Lines         132      137       +5     
==========================================
+ Hits           62       74      +12     
+ Misses         70       63       -7
Impacted Files Coverage Δ
src/basics.jl 71.42% <0%> (-0.45%) ⬇️
src/routing.jl 75.75% <0%> (+3.88%) ⬆️
src/examples/files.jl 25.92% <0%> (+18.51%) ⬆️
src/Mux.jl 77.77% <0%> (+27.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2a060...c8cce80. Read the comment docs.

WebSockets = "104b5d7c-a370-577a-8038-80a2059c5097"

[compat]
AssetRegistry = "0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these dependencies be opened up a bit more?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, although technically only WebSockets can be changed from 1.5 to 1 according to Semver if we want to guarantee non-breakage (because minor releases can have breaking changes while our deps are <1.x).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I meant something like:

HTTP = "0.6, 0.7, 0.8

(Assuming those versions work with the project as well)

@twavv
Copy link

twavv commented Jan 7, 2020

2 cents: I don't think I've ever seen ="0" as a version specifier. I'm not sure that it would actually work as intended (but I always have issues with versioning after breaking things multiple times, so I'm just paranoid now). It's also much easier to relax bounds later (e.g. just patch release with new versions added to compat) than it is to restrict them.

@mattBrzezinski
Copy link
Member

2 cents: I don't think I've ever seen ="0" as a version specifier. I'm not sure that it would actually work as intended (but I always have issues with versioning after breaking things multiple times, so I'm just paranoid now). It's also much easier to relax bounds later (e.g. just patch release with new versions added to compat) than it is to restrict them.

I think my comment above may have got missed as I submitted it as the thread was being resolved?, link.

@jpsamaroo
Copy link
Collaborator Author

I agree, I think I'm going to drop the last commit and just open up WebSockets to "1"

@jpsamaroo jpsamaroo merged commit 7abd82d into master Jan 7, 2020
@jpsamaroo
Copy link
Collaborator Author

Thanks for the help with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants