Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix serve api that integrates websockets #147

Merged
merged 3 commits into from
Oct 14, 2022
Merged

fix serve api that integrates websockets #147

merged 3 commits into from
Oct 14, 2022

Conversation

tanmaykm
Copy link
Member

Have a serve method that accepts an additional port to listen for websockets. Allows serving both general http requests and websocket requests using a single call to serve.

fixes: #146

@tanmaykm
fix serve api that integrates websockets
5a038de 
Have a `serve` method that accepts an additional port to listen for websockets.
Allows serving both general http requests and websocket requests using a single call to `serve`.

fixes: #146
@tanmaykm tanmaykm requested review from quinnj and cmcaine October 12, 2022 09:12
quinnj
quinnj approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; is there a strong reason we don't want to serve both from the same port? We have examples on how to do that around (here)

@tanmaykm
Copy link
Member Author

Thanks for pointing out the example!
Yes, it does look simple to support both on same port. I'll make changes to do that.

@tanmaykm tanmaykm requested a review from quinnj October 12, 2022 16:18
quinnj
quinnj approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks great.

@tanmaykm
Copy link
Member Author

Thanks for the review and suggestions @quinnj !
Should this be merged and tagged?

@tanmaykm
Copy link
Member Author

Will merge and tag in a bit

@tanmaykm tanmaykm merged commit 816fde7 into master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

@cmcaine cmcaine Awaiting requested review from cmcaine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

serve method to integrate websockets broken
2 participants
@tanmaykm @quinnj