-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn websockets integration back on #66
Conversation
Websockets.jl has now been updated. Maybe try closing and reopening? |
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 5 5
Lines 53 53
=======================================
Hits 48 48
Misses 5 5 Continue to review full report at Codecov.
|
Blocked by vtjnash/Pidfile.jl#2 |
But I think if this works on v0.7 we should merge it. It requires Julia 0.7, so nothing will break for 0.6 users, and the situation with Pidfile.jl on 1.0 will resolve itself soon. This seems like a strict improvement and will un-block various downstream projects. |
Pidfile tag PR is open: JuliaLang/METADATA.jl#16851. |
Pidfile tag merged. |
🎉 ! |
Amazing job! Could we simply merge this one, JuliaGizmos/WebIO.jl#169 and JuliaGizmos/Blink.jl#139 ? I think it's difficult otherwise for package developers to test things on travis. I agree with @rdeits that this is a strict improvement anyway as before WebSockets integration was simply not working. |
This is now passing all the tests, so I'd say we should merge it, tag a new release, and then move on to the WebIO and Blink PRs. |
Ready to go? |
Yup, just waiting for someone with merge permissions |
Thanks! |
Can we also get a new tag with this PR included? That will get WebIO and Blink closer to working. |
I added you as a committer so you can do what you need to. |
This is necessary to get WebIO.jl working again on 0.7