Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn websockets integration back on #66

Merged
merged 3 commits into from
Aug 16, 2018
Merged

Conversation

rdeits
Copy link
Collaborator

@rdeits rdeits commented Aug 13, 2018

This is necessary to get WebIO.jl working again on 0.7

@simonbyrne
Copy link
Contributor

Websockets.jl has now been updated. Maybe try closing and reopening?

@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files           5        5           
  Lines          53       53           
=======================================
  Hits           48       48           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b14d8...a852ac2. Read the comment docs.

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 14, 2018

Blocked by vtjnash/Pidfile.jl#2

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 14, 2018

But I think if this works on v0.7 we should merge it. It requires Julia 0.7, so nothing will break for 0.6 users, and the situation with Pidfile.jl on 1.0 will resolve itself soon. This seems like a strict improvement and will un-block various downstream projects.

@tkoolen
Copy link

tkoolen commented Aug 14, 2018

Pidfile tag PR is open: JuliaLang/METADATA.jl#16851.

@tkoolen
Copy link

tkoolen commented Aug 15, 2018

Pidfile tag merged.

@rdeits rdeits closed this Aug 15, 2018
@rdeits rdeits reopened this Aug 15, 2018
@tkoolen
Copy link

tkoolen commented Aug 15, 2018

🎉 !

@piever
Copy link
Collaborator

piever commented Aug 15, 2018

Amazing job! Could we simply merge this one, JuliaGizmos/WebIO.jl#169 and JuliaGizmos/Blink.jl#139 ? I think it's difficult otherwise for package developers to test things on travis. I agree with @rdeits that this is a strict improvement anyway as before WebSockets integration was simply not working.

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 15, 2018

This is now passing all the tests, so I'd say we should merge it, tag a new release, and then move on to the WebIO and Blink PRs.

@tkoolen
Copy link

tkoolen commented Aug 15, 2018

Ready to go?

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 16, 2018

Yup, just waiting for someone with merge permissions

@MikeInnes MikeInnes merged commit 11ac08f into JuliaWeb:master Aug 16, 2018
@MikeInnes
Copy link
Collaborator

Thanks!

@rdeits rdeits deleted the rd/websockets branch August 16, 2018 17:29
@rdeits
Copy link
Collaborator Author

rdeits commented Aug 16, 2018

Can we also get a new tag with this PR included? That will get WebIO and Blink closer to working.

@MikeInnes
Copy link
Collaborator

I added you as a committer so you can do what you need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants