Recommend against using defaults in Production #93
Conversation
jpsamaroo
force-pushed
the
jps/readme-basiccatch-warning
branch
from
07c591f to
cfda1f1
Compare
|
Sensible suggestion, but can we provide some recommendations on what to do, rather than just what not to do? What is our recommendation on the best way to use this in production? |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 54.01% 58.86% +4.85%
==========================================
Files 7 7
Lines 137 141 +4
==========================================
+ Hits 74 83 +9
+ Misses 63 58 -5
Continue to review full report at Codecov.
|
|
That's a great question! I haven't yet run Mux in "production" (still working towards that day), so if you have any concrete ideas I'd be happy to add them. I'll think on this a bit myself. |
|
We might also want to include another middleware that is the same as |
jpsamaroo
force-pushed
the
jps/readme-basiccatch-warning
branch
from
cfda1f1 to
4a91440
Compare
|
@aviks updated per my previous suggestion, we now have |
|
Bump |
| try | ||
| app(req) | ||
| catch e | ||
| showerror(stderr, e, catch_backtrace()) |
There was a problem hiding this comment.
Should this use Base's logging facility? Maybe that is a wider question.
While `Mux.defaults` is great for development and debugging purposes, it should definitely not be used in a Production application, due to the inclusion of the `basiccatch` middleware, which dumps stacktraces to clients. Reword the README to indicate that one should instead roll their own stack.
jpsamaroo
force-pushed
the
jps/readme-basiccatch-warning
branch
2 times, most recently
from
347ce0b to
f37e07b
Compare
jpsamaroo
force-pushed
the
jps/readme-basiccatch-warning
branch
from
f37e07b to
ff15192
Compare
While
Mux.defaultsis great for development and debugging purposes, itshould definitely not be used in a Production application, due to the
inclusion of the
basiccatchmiddleware, which dumps stacktraces toclients. Reword the README to indicate that one should instead roll
their own stack.