More test fixes for Julia v0.7/1.0 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod: .travis.yml Don't test v0.6, add v0.7-alpha
mod: appveyor.yml Rewrite build script for 0.7-alpha
mod: test/REQUIRE Remove JSON, add Requires.
mod: test/frametest.jl 0.7-alpha syntax not caught by the bot:
bits->bitstring
BufferStream-> Base.BufferStream
info -> @info (not obvious)
Conversions (codeunits) are more of a choice.
mod: test/optional/browsertest.jl Comment:Add JSON manually
mod: test/runtests.jl Remove old TODO.
mod: src/WebSockets.jl Import Sockets:TCPSocket
Add Reinterpreted type for internal methods locked_write, write_fragment
modified: examples/chat.jl
modified: README.md modified: appveyor.yml modified: benchmark/functions_benchmark.jl modified: benchmark/ws_hts.jl modified: examples/chat_explore.jl modified: src/HTTP.jl modified: src/HttpServer.jl modified: src/WebSockets.jl modified: test/REQUIRE modified: test/client_server_test.jl modified: test/client_test.jl modified: test/error_test.jl modified: test/frametest.jl modified: test/handshaketest.jl modified: test/optional/browsertest.jl modified: test/optional/functions_open_browsers.jl modified: test/runtests.jl
|
Ahhh, I see the code that sets the |
|
Aha! That sounds important 🙂 |
hustf
reviewed
Aug 12, 2018
| @@ -1,5 +1,3 @@ | |||
| HTTP | |||
| HttpServer | |||
| Requires | |||
|
It's easier to review these together, working locally. Merging. Thank you, rdeits. |
hustf
added a commit
that referenced
this pull request
Aug 12, 2018
* Update examples to fully working state, start dropping HttpServer modified: README.md modified: REQUIRE deleted: examples/chat.jl modified: examples/chat_explore.jl modified: examples/client_repl_input.jl modified: examples/minimal_server_HTTP.jl modified: logutils/logutils_ws.jl modified: src/HTTP.jl modified: src/WebSockets.jl * More test fixes for Julia v0.7/1.0 (#106) * Fix deprecations * Update REQUIRE * Fix tests not including HTTP and HttpServer mod: .travis.yml Don't test v0.6, add v0.7-alpha mod: appveyor.yml Rewrite build script for 0.7-alpha mod: test/REQUIRE Remove JSON, add Requires. mod: test/frametest.jl 0.7-alpha syntax not caught by the bot: bits->bitstring BufferStream-> Base.BufferStream info -> @info (not obvious) Conversions (codeunits) are more of a choice. mod: test/optional/browsertest.jl Comment:Add JSON manually mod: test/runtests.jl Remove old TODO. mod: src/WebSockets.jl Import Sockets:TCPSocket Add Reinterpreted type for internal methods locked_write, write_fragment * modified: README.md Drop release version appveyor badge. * Issue #99 modified: examples/chat.jl * Make some more tests work, Requires syntax, general facelift. modified: README.md modified: appveyor.yml modified: benchmark/functions_benchmark.jl modified: benchmark/ws_hts.jl modified: examples/chat_explore.jl modified: src/HTTP.jl modified: src/HttpServer.jl modified: src/WebSockets.jl modified: test/REQUIRE modified: test/client_server_test.jl modified: test/client_test.jl modified: test/error_test.jl modified: test/frametest.jl modified: test/handshaketest.jl modified: test/optional/browsertest.jl modified: test/optional/functions_open_browsers.jl modified: test/runtests.jl * fix more v0.7 deprecations * drop HttpServer.jl * update CI * start purging HttpServer * update current state * purge more httpserver-related code * remove an unused method * remove unused method * more cleanup * delete more dead code * update expected error message * remove unused requirements * Tests passing locally, delete more HttpServer files. deleted: examples/minimal_server.jl for HttpServer deleted: src/HttpServer.jl modified: test/REQUIRE modified: test/client_test.jl Less strict check ECONN.. number * Update README status. modified: README.md * Reduce warning messages modified: src/HTTP.jl remove warning 'origin' modified: test/error_test.jl global keyword, import WebsocketHandler * modified: test/error_test.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hustf this is a PR against the branch
10aug18_0.7from #105 . Merging will update that PR rather thanmaster.With this branch, I have
pkg> test WebSocketspassing on Julia v0.7.0.