This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Deploy to heroku 2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be dangerous for production apps
|
@zunda Herokuで動きました！すばらしい！！ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
リモートで動かないのは、Action CableがWebSocketの接続元を制限しているからのようです。4b4e726 で接続元の制限をゆるくすることでチャットが実現できました (プロダクションに使うにはこの変更では制限がゆるすぎそうです)。
このプルリクエストには、上記のほかHerokuで動かすのに必要な変更と推奨される変更も含まれています。