IPC GUI ToDo

[MrBurrBurr]

IMPORTANT NOTICE

Development for new ASF UI has begun. Current IPC GUI will not be updated anymore.
This Issue will be migrated to fit the new UI.

New UI should support

• [Config] Do not include default properties when updating config
• [Config] Implement parsing helper to editor and generator
• [Global] Load fallback strings (english) if dynamic loaded i18n strings are empty
• [Config] Implement wiki parser for config properties
  Show tooltip/box with wiki info about the selected config property - Consider this suggestion
• [Config] Think about using Driver.js for first visit
  Wiki parser for Editor and Generator, Whats new?, Tips&Tricks, missing input etc.
• [Config] Implement option to directly create new bot config via POST /Api/Bot/{BotName}
• [Bots] Auto detect order of keys in BGR (Suggestion)
• [Bots] Implement DELETE /Api/GamesToRedeemInBackground/{Bot}

Suggestions

• [Global] Think about NLog layout
• [Commands] Add "quick commands" feature (Suggestion)

Final Steps

1. Check nightmode support
2. Check i18n support

FAQ

1. Error 1006 when viewing Log page
   This is getting caused by one of the following points:
   1. Adblocker - Add IPC GUI to whitelist
   2. Windows 7 - Websockets are not supported on win7
   3. nginx - Check websocket proxying

[MrMarble]

There's a bug with the config editor in the function prepareConfigForSaving

The function loads the configuration that it retrieved from the API, the problem is that if one of the properties has a default value, is not included in the ASF response so when the function prepareConfigForSaving loop through all the keys in the config to update them with the one in the forms if the property had a default value is not going to be part of the loop so is never going to be changed.

function prepareConfigForSaving() {
    var botName = $('#saveButton').data('BotName'),
        config = globalConfig; //Here it loads the config object that ASF sent in the ajax request 

    for (var key in config) {
...

for example if the property RedeemingPreferences has the default value 0 the API endpoint /Api/Bot/Bot_name is not going to have it because as in the BotConfig Wiki says:

Typically this object will include only a subset of all config properties - those that the user has modified (minimalistic config).

So if the user try to change that value as there's not a entry in the globalConfig object is not going to be saved.

I think 3 ways of possible fixes:

• Change ASF Behavior
  • Adding a parameter to the /Api/Bot/{Bot} endpoint so it returns all the properties
  • Changing the response of the endpoint without adding extra parameters
• Looping through the form elements instead of the globalConfig
• Pre populating the globalConfig object with all the properties and the default values that will be filled by the ajax response

Maybe I can create a pull request but is a bit late where I live so it will have to wait

[MrBurrBurr]

Here is a short answer since I am at the airport right now:

Everything should be fine from ASF side, so there is no need to change anything here.
What needs to be done is very simple: We need to get globalDefaultConfig before updating those properties with corresponding config values from loaded config.

I am aware of what is broken right now and I know how to fix it. I just didnt have any time to do it.

Thank you very much for your time and work!

[blackzafiqz]

Hi , when I use reverse proxy using apache2, this error occured "You failed to authenticate properly too many times, try again in an hour.". How can I disable the lockdown?

[Abrynos]

This error occurs because ASF wasn't provided the correct password.

As this is a very important security feature to refuse anyone access to your steam accounts who tries to get access to your ASF instance by brute-forcing the IPC password this can NOT be deactivated (and will never be deactivateable [if that word exists]). you can however restart ASF itself which should clear the 1 hour timer that will let you retry after said time interval.

[blackzafiqz]

Okay then thank you

…

On Sat, Aug 25, 2018, 9:23 PM Abrynos ***@***.***> wrote: This error occurs because ASF wasn't provided the correct password. As this is a very important security feature to refuse anyone access to your steam accounts who tries to get access to your ASF instance by brute-forcing the IPC password this can NOT be deactivated (and will never be deactivateable [if that word exists]). you can however restart ASF itself which should clear the 1 hour timer that will let you retry after said time interval. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#869 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQRpRGdlOIrJO7Y4R-GasYpHGEXbjvUTks5uUU_sgaJpZM4VpGAC> .

[Abrynos]

Bug Report

Description

When clicking the key-icon by a bot on bots.html and closing the popup a button will still be shown when reopening the popup, despite not belonging there

Steps to reproduce

1. Go to /pages/bots.html
2. Click the key-icon of a bot
3. Click on the "View unused keys" or "View used keys" tab
4. Click the Cancel-button on the bottom of the popup
5. Click the key-icon of the same bot again (also works if you open up the popup for another bot and then return to the original one)
6. The Download button is still visible despite being on the "Add keys" tab

Edit: screenshot

[MrBurrBurr]

Thank you for reporting this!

This bug got already fixed here.

[JustArchi]

Quite important bug to the collection:

Right now IPC GUI assumes that it's always running on the root domain, for example on 127.0.0.1 or example.com.

This assumption will no longer work with ASF 3.3.0.7+ that introduces Kestrel http server (#898) that fixes missing functionality asked in #840. Moreover, this assumption should never happen in the first place since users could already run reverse proxies before ASF with url rewriting and use whatever URLs they wanted, but let's assume this was rather rare until now.

User might now run ASF's IPC server with custom base path, such as 127.0.0.1:1242/IPC or example.com/ASF. IPC GUI is hardcoded in a lot of places to always ask for /Api/XXX which is wrong, as in this case /Api/XXX will not work, correct usage would be /prefix/Api/XXX, or just how it should be done in the first place: Api/XXX. Same goes for other parts, e.g. /locale/strings.json.

Please consider it one of priority fixes for new update, thank you in advance @MrBurrBurr.

[MrBurrBurr]

I will look into this, thank you for reporting.