Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flash console window on input request on Windows #3158

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Flash console window on input request on Windows #3158

merged 8 commits into from
Mar 14, 2024

Conversation

ezhevita
Copy link
Member

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

New functionality

Adds flashing console window on Windows when ASF requests the user input.

Changed functionality

None.

Removed functionality

None.

Additional info

Resolves #2998.

JustArchi
JustArchi approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🏆

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. labels Mar 13, 2024
@JustArchi JustArchi merged commit 8642b07 into JustArchiNET:main Mar 14, 2024
21 checks passed
@ezhevita ezhevita deleted the flash-console-window branch March 14, 2024 00:52
ezhevita added a commit to ezhevita/ArchiSteamFarm that referenced this pull request Mar 14, 2024
@ezhevita
Misc minimize fixes after JustArchiNET#3158
da62aaa
JustArchi pushed a commit that referenced this pull request Mar 14, 2024
@ezhevita
Misc minimize fixes after #3158 (#3159)
21c9dac 
* Misc minimize fixes after #3158

* only "iconify" escape sequence support is needed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Abrynos Abrynos Abrynos left review comments

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🏁 Finished Issues marked with this label were finished already and no further work is required on them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ASF console window flash on input request and stop flashing once provided
3 participants
@ezhevita @JustArchi @Abrynos