-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json contains invalid entries #169
Comments
Hmm, or are these generated as of: |
I can understand why these files are generated, though on a personal note, it's a bit challenging because every other VS Code extension has these files vendored in, which makes them much easier to scrape from GitHub for things like https://github.com/bolinfest/monaco-tm. |
As noted on: JustusAdam#169 The grammar files are not vendored into the repo by default, which is inconvenient if you want to scrape the TextMate grammars using ordinary GET requests to GitHub. This is the result of running `make all` at c71c5d0.
Are you only scraping grammars from vscode? If so, wouldn't it make sense to scrape the marketplace directly instead of going through github? |
I could foresee issues with scraping the marketplace, as that has a more restrictive license which is why things like open-vsx exist, and projects like VSCodium use that instead now, since there is doubt about if even a fork can use the marketplace itself. I.e. it has this in its Terms of Use:
which may cause issues. I bumped into this issue since I'm a member of an editor project that also consumes VSCode extensions and we haven't gotten the tasks API fully hooked up for the compile on install step, which causes issues here obviously. It seems somewhat odd to have every user compile the YML -> JSON, rather than have it as a one time step as part of the CI/Extension building then publishing, though I'm also very aware I could be missing a lot of context here! Obviously we also need to get the tasks API hooked up, but thought it was worth checking if there was a specific reason behind this. |
The file
./syntaxes/cabal.json
does not exist:language-haskell/package.json
Line 139 in c71c5d0
The file
syntaxes/literateHaskell.json
does not exist:language-haskell/package.json
Line 154 in c71c5d0
The text was updated successfully, but these errors were encountered: