Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json contains invalid entries #169

Open
bolinfest opened this issue Jun 29, 2020 · 4 comments
Open

package.json contains invalid entries #169

bolinfest opened this issue Jun 29, 2020 · 4 comments

Comments

@bolinfest
Copy link

The file ./syntaxes/cabal.json does not exist:

"path": "./syntaxes/cabal.json"

The file syntaxes/literateHaskell.json does not exist:

"path": "./syntaxes/literateHaskell.json"

@bolinfest
Copy link
Author

Hmm, or are these generated as of:

1c5b9c4

@bolinfest
Copy link
Author

I can understand why these files are generated, though on a personal note, it's a bit challenging because every other VS Code extension has these files vendored in, which makes them much easier to scrape from GitHub for things like https://github.com/bolinfest/monaco-tm.

bolinfest added a commit to bolinfest/language-haskell that referenced this issue Jun 29, 2020
As noted on:
JustusAdam#169

The grammar files are not vendored into the repo by default,
which is inconvenient if you want to scrape the TextMate grammars
using ordinary GET requests to GitHub.

This is the result of running `make all` at
c71c5d0.
@JustusAdam
Copy link
Owner

Are you only scraping grammars from vscode? If so, wouldn't it make sense to scrape the marketplace directly instead of going through github?
Presumably the marketplace files have a way more regular structure.

@CrossR
Copy link

CrossR commented Aug 16, 2020

I could foresee issues with scraping the marketplace, as that has a more restrictive license which is why things like open-vsx exist, and projects like VSCodium use that instead now, since there is doubt about if even a fork can use the marketplace itself.

I.e. it has this in its Terms of Use:

You may not access, search, obtain or attempt to obtain any Offerings, materials, or information through any means other than Microsoft’s publicly supported interfaces (including, without limitation, through automated harvesting, ‘spidering’ or ‘scraping’ the Marketplace).

which may cause issues.

I bumped into this issue since I'm a member of an editor project that also consumes VSCode extensions and we haven't gotten the tasks API fully hooked up for the compile on install step, which causes issues here obviously. It seems somewhat odd to have every user compile the YML -> JSON, rather than have it as a one time step as part of the CI/Extension building then publishing, though I'm also very aware I could be missing a lot of context here! Obviously we also need to get the tasks API hooked up, but thought it was worth checking if there was a specific reason behind this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants