Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown support for literate haskell and cabal #56

Merged
merged 1 commit into from
May 12, 2018

Conversation

glebec
Copy link
Contributor

@glebec glebec commented May 11, 2018

Closes #48.

In addition to #55, which added markdown code fence support for haskell and hs, this PR:

  • adds support for Literate Haskell using literate-haskell, lhaskell, and lhs
  • adds support for Cabal using cabal
  • makes support stricter by adding word boundaries \b to the regex for matching languages

One thing this PR does not do is add any language to the README advertising or documenting this support. I don't know that it's necessary – this is a naturally discoverable, even expected, feature. I leave it up to you to decide how or if you want to incorporate that.

@JustusAdam
Copy link
Owner

Thanks a lot for this.

this is a naturally discoverable, even expected, feature.

I agree, and I won't separately advertise it. You can expect your name to show up in the changelog though 😉.

@JustusAdam JustusAdam merged commit e2dd111 into JustusAdam:master May 12, 2018
@glebec glebec deleted the f/markdown-cabal-lhs branch May 12, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants