Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cc crate to 1.0.86 #848

Merged
merged 1 commit into from
Feb 21, 2024
Merged

update cc crate to 1.0.86 #848

merged 1 commit into from
Feb 21, 2024

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Feb 13, 2024

1.0.85 includes rust-lang/cc-rs#918 and the macOS deployment target issue has been fixed.

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems cc 1.0.85 was yanked 😨

@Be-ing
Copy link
Contributor Author

Be-ing commented Feb 14, 2024

rust-lang/cc-rs#948 :/ ...

@Be-ing Be-ing marked this pull request as draft February 14, 2024 19:08
@Be-ing Be-ing changed the title update cc crate to 1.0.85 update cc crate to 1.0.86 Feb 21, 2024
@Be-ing Be-ing marked this pull request as ready for review February 21, 2024 08:57
@Be-ing
Copy link
Contributor Author

Be-ing commented Feb 21, 2024

cc 1.0.86 has been released and this branch updated.

@Be-ing
Copy link
Contributor Author

Be-ing commented Feb 21, 2024

There's a spammy warning from cc on Ubuntu CI, but I can't reproduce it locally on Fedora 39. I think it's fine to merge with that minor inconvenience.

1.0.86 includes rust-lang/cc-rs#918
and the macOS deployment target issue has been fixed.
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) February 21, 2024 10:57
@ahayzen-kdab ahayzen-kdab dismissed LeonMatthesKDAB’s stale review February 21, 2024 11:18

1.0.86 is now available

@ahayzen-kdab ahayzen-kdab merged commit 032dca2 into KDAB:main Feb 21, 2024
10 checks passed
@Be-ing Be-ing deleted the update_cc branch February 21, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants