Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song Choice #32

Closed
Mennaruuk opened this issue Mar 17, 2022 · 8 comments
Closed

Song Choice #32

Mennaruuk opened this issue Mar 17, 2022 · 8 comments
Assignees
Labels
bug Something isn't working deployed This issue has been fixed/implmented and has been released

Comments

@Mennaruuk
Copy link

Describe the bug
Some songs are different from the ones in Spotify. It looks like spotube is fetching the top YouTube Music result, which sometimes can be different.

To Reproduce
Steps to reproduce the behavior:

  1. Add a song like Chasing Cars by Snow Patrol to your playlist
  2. Play it

Around 2:09, Gary sings:

Let's waste time
Chasing cars
Around our heads.

Then the beat drops.

In reality, there is another stanza following that before the beat drops:

I need your grace
To remind me
To find my own

Expected behavior
I want spotube to get the original song. This means that most of the time, official music videos are not good for this because there is a whole bunch of other stuff added (it's a video). But even with audio, I feel like there should be preference given to channels that make lyrics videos such as 7clouds or DopeLyrics, they usually do a good job at cutting out all the fluff while maintaining integrity.

Installation Source/Method

Desktop (please complete the following information):

  • OS: Windows
  • Version: v1.2.0

Additional context
Thanks for your assistance.

@Mennaruuk Mennaruuk added the bug Something isn't working label Mar 17, 2022
@masasin
Copy link

masasin commented May 14, 2022

Can confirm that this still happens. An example is most things by ARASHI. e.g. Hitomi no Naka no Galaxy gives you a fan doing her own cover.

https://www.youtube.com/watch?v=x4of4ydLOjo&t=0

There are better versions, including many with titles that match better, but they don't get played.

@KRTirtho
Copy link
Owner

KRTirtho commented May 16, 2022

Spotube ranks tracks by track name, artist(s) name(s), author & views
Ranking system is followed by:

  • Checks if a youtube result contains the complete title (without artists) of the Spotify Track
  • Checks if the primary artist of Spotify is the author of the channel (not that important)
  • Checks if all the Spotify artist's name(s) are included in the Youtube result's title
  • Checks if the YouTube result is not a Live Video or a crop/cut from a Live Video

See if all the checks apply for the track you're reporting

@masasin
Copy link

masasin commented May 16, 2022 via email

@braboobssiere
Copy link

braboobssiere commented Aug 3, 2022

is it possible to custom search parameters?

i want to strictly search by channel title, song title, artist, duration (to match the spotify length) +-2 second in that order

@koboingangkang
Copy link

Spotube ranks tracks by track name, artist(s) name(s), author & views Ranking system is followed by:

  • Checks if a youtube result contains the complete title (without artists) of the Spotify Track
  • Checks if the primary artist of Spotify is the author of the channel (not that important)
  • Checks if all the Spotify artist's name(s) are included in the Youtube result's title
  • Checks if the YouTube result is not a Live Video or a crop/cut from a Live Video

See if all the checks apply for the track you're reporting

if we are to play tracks from spotify (our playlist or not), why spotube has to research again? why doesn't it play from song(s) based on songs id directly? moreover, can we opt out youtube?

@Elendil211
Copy link

Elendil211 commented Oct 25, 2022

I get very good results with this search term: $MAIN_ARTIST $TITLE $FEATURED_ARTISTS, description:\"Auto-generated by YouTube.\" in combination with YouTube's Top choice track match algorithm.
The thing at the end leads to results from youtube music being preferred. It's also not perfect, though. Sometimes Spotube also finds different results than what I find when searching in the browser. Matching the length would probably help very much.

@KRTirtho
Copy link
Owner

KRTirtho commented Jan 6, 2023

After v2.6.0 users can override search result and can select from the range of results found initially. And it is known as Alternative Track Sources
The selected track source will be cached to disk, so next time listening to it will load the user overridden result as source
This should resolve the issue for now

@vehosah
Copy link

vehosah commented Mar 24, 2023

For me it still plays the audio from the video 🙁

@KRTirtho KRTirtho moved this from Backlog to Done in Spotube Board Apr 27, 2023
@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Apr 27, 2023
@github-project-automation github-project-automation bot moved this from Deployed to Done in Spotube Board Apr 27, 2023
@RaptaG RaptaG moved this from Done to Deployed in Spotube Board Jul 2, 2023
@KRTirtho KRTirtho added the deployed This issue has been fixed/implmented and has been released label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployed This issue has been fixed/implmented and has been released
Projects
Status: Deployed
Development

No branches or pull requests

8 participants