Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular Service Module Lander Tank not getting SM-I, SM-II etc #69

Closed
lpgagnon opened this issue Sep 6, 2021 · 2 comments
Closed

Modular Service Module Lander Tank not getting SM-I, SM-II etc #69

lpgagnon opened this issue Sep 6, 2021 · 2 comments

Comments

@lpgagnon
Copy link
Contributor

lpgagnon commented Sep 6, 2021

As discussed on discord

Patch ordering issue, the ServiceModule->SM-I/II... substitution runs before the lander tank gets defined

Easiest is to just replace the type=ServiceModule by a copy-paste of the full set directly in newtanks.cfg (they're both NEEDS:RO, so there's no scenario where the ServiceModule type "should" be left alone), but yuck
pap1723 added a commit that referenced this issue Jan 19, 2022
@pap1723
Fix Issue #69 Where Lander Tanks were not getting the proper SM Tanks
69e76e3
@pap1723
Copy link
Contributor

pap1723 commented Jan 19, 2022

Fixed with 69e76e3

@pap1723 pap1723 closed this as completed Jan 19, 2022
@arrowmaster
Copy link
Contributor

@PART[ROT-ProbeCore|ROT-*]:AFTER[zzROTanks]:NEEDS[RealismOverhaul] did not fix the problem and caused Modular Tank (Service Module) to become broken too.

I tested @PART[ROT-ProbeCore|ROT-*]:FOR[zzzROTanks]:NEEDS[RealismOverhaul] and both tanks are now working correctly.

arrowmaster added a commit to arrowmaster/ROTanks that referenced this issue Feb 6, 2022
@arrowmaster
Actually Fix Issue KSP-RO#69 Where Lander Tanks were not getting the …
344933d 
…proper SM Tanks
DRVeyl pushed a commit that referenced this issue Mar 14, 2022
@arrowmaster
Actually Fix Issue #69 Where Lander Tanks were not getting the proper…
fb501f0 
… SM Tanks (#70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arrowmaster @lpgagnon @pap1723