Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc-Radial tank tweaks #85

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Misc-Radial tank tweaks #85

merged 1 commit into from
Feb 12, 2023

Conversation

lpgagnon
Copy link
Contributor

@lpgagnon lpgagnon commented Feb 4, 2023

  • Unbreak the Restock variants; they were missing all the defaults and ended up with no tank volume at all.
  • Squad-xenon tank volume was 10x off.
  • Squad-round tank wasn't round.
  • The 95% handwaved volume multiplier is more generous than I realized for spheres. Add special treatement for spheres.

@lpgagnon
Misc-Radial tank tweaks
41636fb 
- Unbreak the Restock variants; they were missing all the defaults
  and ended up with no tank volume at all.
- Squad-xenon tank volume was 10x off.
- Squad-round tank wasn't round.
- The 95% handwaved volume multiplier is more generous than I realized
  for spheres. Add special treatement for spheres.
@Capkirk123
Copy link
Member

Unrelated, but it appears the shielded misc tanks still have a 1073 K temperature limit. They probably need to have their temperature patched in :FOR[RealismOverhaul] so it doesn't get hit with the global patch.

@lpgagnon
Copy link
Contributor Author

Unrelated, but it appears the shielded misc tanks still have a 1073 K temperature limit. They probably need to have their temperature patched in :FOR[RealismOverhaul] so it doesn't get hit with the global patch.

Will fix (in RO). For some reason I had imagined setting roTankType=spaceplane took care of that

@Capkirk123 Capkirk123 merged commit 3587b23 into KSP-RO:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpgagnon @Capkirk123