Misaligned diagonals for DataFrame

[jjzha]

Hi,

Love this repo, thanks for doing this!

Issue

I have a small issue with respect to the new DataFrame feature that you implemented. Here I have misaligned diagonals where I would get close to stochastic dominance of a model compared to itself.

Reproduce Issue

I have the following dictionary:
d = {'x': array([59.13, 58.03, 59.18, 58.78, 58.5 ]), 'y': array([58.13, 59.19, 59.94, 60.08, 59.85]), 'z': array([58.77, 58.86, 59.58, 59.59, 59.64]), 'w': array([58.16, 58.49, 59.87, 58.94, 58.96])}

I use the following line of code:
print(multi_aso(d, confidence_level=0.05, return_df=True))

I get the following result:

    x         y            z            w
x    1.000000  1.000000     0.202027       0.0
y    1.000000  0.101093     0.000000       0.0
z    0.202027  0.000000     1.000000       0.0
w    0.000000  0.000000     0.000000       1.0

Where I think the diagonal for the (y, y) pair shouldn't be correct.

Thanks for reading!

[jjzha]

I also checked it without returning df. The same error persists. So there might be a different underlying issue.

[Kaleidophon]

Fixed in the above commit and version 1.1.3 is already published on PyPI! Thank you so much for discovering and reporting this bug.