Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a confirmation dialog when DataMapper step is to be deleted, with also offering an option to delete associated mapping file (XSLT) #1749

Closed
igarashitm opened this issue Oct 4, 2024 · 0 comments · Fixed by KaotoIO/kaoto-datamapper-integration#102
Assignees
Labels
bug Something isn't working
Milestone

Comments

@igarashitm
Copy link
Contributor

igarashitm commented Oct 4, 2024

Describe the Bug

Currently the DataMapper step is deleted without confirmation dialog. Show a confirmation dialog, but offer 3 options:

  1. Delete DataMapper step and associated mapping file (XSLT)
  2. Delete DataMapper step, but keep the associated mapping file
  3. Cancel

cf. KaotoIO/kaoto-datamapper-integration#94

Need an enhancement to the confirmation modal provider, better to do in upstream first and port here.
#1537

Update

One more thing to consider. We should change the behvior of onDelete callback depending on the answer from confirmation dialog above, i.e. if mapping file is to be removed or not. We need a way to propagate that decision to onDelete.

Steps to Reproduce the Bug or Issue

No response

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 0.30.0]
@igarashitm igarashitm added the bug Something isn't working label Oct 4, 2024
@igarashitm igarashitm self-assigned this Oct 4, 2024
@igarashitm igarashitm changed the title Show a confirmation dialog when DataMapper step is to be deleted, with also offering an option to delete associated mapping file (XSLT) as well Show a confirmation dialog when DataMapper step is to be deleted, with also offering an option to delete associated mapping file (XSLT) Oct 4, 2024
@lhein lhein transferred this issue from KaotoIO/kaoto-datamapper-integration Dec 9, 2024
@lhein lhein added this to the 2.3.0 milestone Dec 9, 2024
@lhein lhein moved this from New to Done in Kanban Board Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants