Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance confirmation modal provider to offer customizable options/buttons #1537

Closed
igarashitm opened this issue Oct 4, 2024 · 0 comments · Fixed by #1545
Closed

Enhance confirmation modal provider to offer customizable options/buttons #1537

igarashitm opened this issue Oct 4, 2024 · 0 comments · Fixed by #1545
Assignees
@igarashitm
Labels
canvas/visualization Canvas-related issues enhancement New feature or request

Comments

@igarashitm
Copy link
Contributor

Please describe the feature that you want to propose

Not only confirm and cancel, support providing custom options in the modal, then the callback receives a button index which indicates which button is clicked.
The default should stay confirm and cancel, but still needs the change for handling returns from boolean to number.
@igarashitm igarashitm added enhancement New feature or request canvas/visualization Canvas-related issues labels Oct 4, 2024
@igarashitm igarashitm self-assigned this Oct 4, 2024
@igarashitm igarashitm mentioned this issue Dec 9, 2024
Closed
@tplevko tplevko moved this from New to Todo in Kanban Board Oct 8, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 8, 2024
@igarashitm
fix: Enhance confirmation modal provider to offer customizable option…
952134e 
…s/buttons

Fixes: KaotoIO#1537
@igarashitm igarashitm mentioned this issue Oct 8, 2024
Merged
igarashitm added a commit that referenced this issue Oct 9, 2024
@igarashitm
fix: Enhance confirmation modal provider to offer customizable option…
8e975a0 
…s/buttons

Fixes: #1537
@github-project-automation github-project-automation bot moved this from Todo to Done in Kanban Board Oct 9, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 11, 2024
@igarashitm
chore: Use string key instead of number for modal action key (KaotoIO…
c53bc12 
…#1537)
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 11, 2024
@igarashitm
chore: Use string key instead of number for modal action key (KaotoIO…
c9f960c 
…#1537)
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 11, 2024
@igarashitm
chore: Use string key instead of number for modal action key (KaotoIO…
3c611f6 
…#1537)
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 11, 2024
@igarashitm
chore: Use string key instead of number for modal action key (KaotoIO…
16de62a 
…#1537)
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 11, 2024
@igarashitm
chore: Use string key instead of number for modal action key (KaotoIO…
21803d0 
…#1537)
lordrip pushed a commit that referenced this issue Oct 14, 2024
@igarashitm @lordrip
chore: Use string key instead of number for modal action key (#1537)
a887b87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
canvas/visualization Canvas-related issues enhancement New feature or request
Projects
Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Enhance confirmation modal provider to offer customizable option… igarashitm/kaoto
1 participant
@igarashitm