Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask sensitive configuration values #285

Closed
lhein opened this issue Nov 3, 2023 · 4 comments · Fixed by #1059
Closed

Mask sensitive configuration values #285

lhein opened this issue Nov 3, 2023 · 4 comments · Fixed by #1059
Assignees
@igarashitm
Labels
enhancement New feature or request on hold Issues or pull requests that are waiting for something question Further information is requested ui/ux This issue is about improving the UI / UX
Milestone
2.0.0

Comments

@lhein
Copy link
Contributor

lhein commented Nov 3, 2023

Please describe the feature that you want to propose

The camel catalog provides the information on each config parameter if it contains sensitive information or not via the attribute secret. If that attribute is set to true we should put a mask on the input field. (PF5 has ready to use component for such cases)
@lhein lhein moved this from New to Todo in Kanban Board Nov 3, 2023
@lhein lhein moved this from Todo to Backlog in Kanban Board Nov 3, 2023
@lordrip lordrip added this to the Feature Parity milestone Nov 7, 2023
@lhein lhein moved this from Backlog to Todo in Kanban Board Nov 7, 2023
@lhein
Copy link
Contributor Author

lhein commented Nov 7, 2023

This needs further investigation as usually users would not put in a password directly but rather reference a secret or property holding that value.

@lhein lhein added enhancement New feature or request question Further information is requested on hold Issues or pull requests that are waiting for something labels Nov 8, 2023
@lhein lhein removed this from the Polishing UI-UX milestone Nov 30, 2023
@lhein lhein moved this from Todo to Backlog in Kanban Board Nov 30, 2023
@lhein lhein added the ui/ux This issue is about improving the UI / UX label Dec 5, 2023
@lhein lhein mentioned this issue Apr 4, 2024
Closed
@lhein
Copy link
Contributor Author

lhein commented Apr 30, 2024

https://www.patternfly.org/components/password-generator

@lhein lhein added this to the 2.0.0 milestone Apr 30, 2024
@lhein lhein moved this from Backlog to Todo in Kanban Board Apr 30, 2024
@igarashitm
Copy link
Contributor

What do we want to do for when a user wants to put a property placeholder? we should somehow provide a way to disable the masking for that.

@lhein
Copy link
Contributor Author

lhein commented May 2, 2024

with the password generator from PF users can toggle visibility. Maybe that is enough?

@igarashitm igarashitm self-assigned this May 2, 2024
@igarashitm igarashitm moved this from Todo to In Progress in Kanban Board May 2, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
e0c0eaa 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
@igarashitm igarashitm mentioned this issue May 3, 2024
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
331fc5f 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
31b15eb 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
igarashitm added a commit to igarashitm/kaoto that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
54b4425 
… password`

Fixes: KaotoIO#285
Fixes: KaotoIO#503
igarashitm added a commit that referenced this issue May 3, 2024
@igarashitm
fix: Add PasswordField to mask input value of the field with `format:…
51cfa6b 
… password`

Fixes: #285
Fixes: #503
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban Board May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
enhancement New feature or request on hold Issues or pull requests that are waiting for something question Further information is requested ui/ux This issue is about improving the UI / UX
Projects
Kanban Board
Archived in project
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

fix: Add PasswordField to mask input value of the field with `format:… igarashitm/kaoto
3 participants
@igarashitm @lhein @lordrip