Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression Configuration is not prefilled correctly #371

Closed
lhein opened this issue Nov 19, 2023 · 5 comments · Fixed by #438
Closed

Expression Configuration is not prefilled correctly #371

lhein opened this issue Nov 19, 2023 · 5 comments · Fixed by #438
Assignees
Labels
bug Something isn't working canvas/visualization Canvas-related issues
Milestone

Comments

@lhein
Copy link
Contributor

lhein commented Nov 19, 2023

You can see in the screenshot that the source shows a constant expression with value 404 but the expression field in the config panel is not showing that value.

Image

Additionally in the example shown above the setBody in the same when clause also has an error. While the source says its using constant and an empty string, the config panel shows Simple instead.

grafik

@lhein lhein converted this from a draft issue Nov 19, 2023
@lhein lhein added this to the Feature Parity milestone Nov 19, 2023
@lhein lhein added bug Something isn't working canvas/visualization Canvas-related issues labels Nov 19, 2023
@lhein lhein moved this from New to Todo in Kanban Board Nov 19, 2023
@lhein
Copy link
Contributor Author

lhein commented Nov 19, 2023

The missing values seem to be caused by the use of numbers instead of strings. Once I enclose the value with double quotes, the value shows up fine in the config panel.

@igarashitm
Copy link
Contributor

@lhein good catch, can you attach the source code?

@igarashitm
Copy link
Contributor

@igarashitm igarashitm self-assigned this Nov 20, 2023
@lhein lhein moved this from Todo to In Progress in Kanban Board Nov 20, 2023
@lhein
Copy link
Contributor Author

lhein commented Nov 20, 2023

related to #332 ?

@igarashitm igarashitm moved this from In Progress to Todo in Kanban Board Nov 21, 2023
@igarashitm igarashitm moved this from Todo to In Progress in Kanban Board Nov 27, 2023
@igarashitm igarashitm moved this from In Progress to Todo in Kanban Board Nov 27, 2023
@igarashitm igarashitm moved this from Todo to In Progress in Kanban Board Nov 27, 2023
@igarashitm
Copy link
Contributor

igarashitm commented Nov 28, 2023

uniforms throws away the values if the type is not right (schema says it's string but the actual value is a number). At the time it comes to CustomAutoField, the value is already undefined. We might need to enforce it to be a string, possibly by customizing the JSONSchemaBridge
Another option I thought was to convert all primitive values in YAML to string, but there ARE some properties that's actually number type in the schema...

No not at all, sorry uniforms, was just my stupid bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working canvas/visualization Canvas-related issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants