Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make enum values accept strings additionally #512

Closed
lhein opened this issue Dec 5, 2023 · 5 comments · Fixed by #737
Closed

make enum values accept strings additionally #512

lhein opened this issue Dec 5, 2023 · 5 comments · Fixed by #737
Assignees
Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Milestone

Comments

@lhein
Copy link
Contributor

lhein commented Dec 5, 2023

when trying to create a Kamelet (and probably in any other case where we have enums in a drop down box) I would like to put in a property placeholder but the drop down prevents that. I have to later on switch to the source view and add it there.

Image

@lhein lhein converted this from a draft issue Dec 5, 2023
@lhein lhein added enhancement New feature or request canvas/config-form Configuration form related issues labels Dec 5, 2023
@lhein lhein added this to the 2.0.0 milestone Dec 5, 2023
@lhein lhein moved this from New to Todo in Kanban Board Dec 5, 2023
@igarashitm
Copy link
Contributor

Same for boolean checkbox. Also see #494

Two options in my mind

  1. Add a tiny button next to and say Use placeholder, once clicked it's turned into a text field
  2. Always use editable dropdown for enum and boolean. Note that in this case boolean field is shown with text, true or false

I personally prefer No.1

@igarashitm
Copy link
Contributor

Also take password field into account - #503

@lhein
Copy link
Contributor Author

lhein commented Dec 8, 2023

is shown with text, true or false
It could actually also be YES and NO. I think that option 2 is probably the more flexible approach.

@igarashitm
Copy link
Contributor

Couldn't it end up like user input true, then it's shown as YES then they complains about it? 😆
Also in that case the free text input would be better limited to only a property placeholder

And what to do with password mask - #503?

@igarashitm
Copy link
Contributor

One another thing is that once #494 is implemented, the enum field could get 2 set of dromdowns, 1 is for enum values and the other is for existing properties. Maybe switch by seeing if {{ is typed or not?

@lordrip lordrip removed their assignment Dec 12, 2023
@igarashitm igarashitm modified the milestones: 2.0.0 TP, 2.0.0 Jan 10, 2024
@lhein lhein modified the milestones: 2.0.0, 2.0.0 TP Jan 10, 2024
@lhein lhein moved this from Todo to In Progress in Kanban Board Jan 16, 2024
@lordrip lordrip moved this from In Progress to Todo in Kanban Board Jan 17, 2024
@lordrip lordrip removed their assignment Jan 17, 2024
@lhein lhein modified the milestones: 2.0.0 TP1, 2.0.0 TP2 Jan 18, 2024
@lordrip lordrip moved this from Todo to In Review in Kanban Board Jan 26, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants