fix(677) enable users to enter text into drop down boxes #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
approved these changes
Jan 29, 2024
Comment on lines
82
to
99
| if (value) { | ||
| if (value === 'create') { | ||
| if (!allOptions.some((item) => item.value === filterValue)) { | ||
| allOptions = [...allOptions, { value: filterValue, children: filterValue }]; | ||
| } | ||
| setSelected(filterValue); | ||
| setOnCreation(!onCreation); | ||
| props.onChange(filterValue); | ||
| setFilterValue(''); | ||
| } else { | ||
| setInputValue(value as string); | ||
| setFilterValue(''); | ||
| setSelected(value as string); | ||
| props.onChange(value as string); | ||
| } | ||
| } | ||
| setIsOpen(false); | ||
| setFocusedItemIndex(null); | ||
| setActiveItem(null); | ||
| }; |
There was a problem hiding this comment.
[curious-question]: Wouldn't this nested if be simplified as:
if (value === 'create') {
if (!allOptions.some((item) => item.value === filterValue)) {
allOptions = [...allOptions, { value: filterValue, children: filterValue }];
}
setSelected(filterValue);
setOnCreation(!onCreation);
props.onChange(filterValue);
setFilterValue('');
} else {
setInputValue(value as string);
setFilterValue('');
setSelected(value as string);
props.onChange(value as string);
}
}
setIsOpen(false);
setFocusedItemIndex(null);
setActiveItem(null);
};There was a problem hiding this comment.
yes, you're right, the first check was redundant. Updated.
|
|
||
| TypeaheadField.defaultProps = {}; | ||
|
|
||
| export default connectField(TypeaheadField); |
There was a problem hiding this comment.
Could export this component with a name?
As an example, like we do for the DisabledField
export const DisabledField = connectField((props: ConnectedFieldProps<CustomStepsFieldProps>) => {
return (
<Card>
<CardTitle>{props.label}</CardTitle>
<CardBody>
<ExpandableDetails details={props}>
<p>Configuring this field is not yet supported</p>
</ExpandableDetails>
</CardBody>
</Card>
);
});There was a problem hiding this comment.
Sure, updated to export with a name.
tplevko
force-pushed
the
issue_677
branch
2 times, most recently
from
79f5604 to
0c9a98c
Compare
lordrip
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #677
fix: #512
With the typeahead with create
vokoscreenNG-2024-01-26_13-34-14.mp4