Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Bean configuration UI #8

Closed
igarashitm opened this issue Aug 9, 2023 · 4 comments · Fixed by #166
Closed

Port Bean configuration UI #8

igarashitm opened this issue Aug 9, 2023 · 4 comments · Fixed by #166
Assignees
@igarashitm
Milestone
2.0.0 TP1

Comments

@igarashitm
Copy link
Contributor

Please describe the feature that you want to propose

Port Bean configuration UI (MetadataEditor component) from kaoto-ui.
@igarashitm igarashitm self-assigned this Aug 9, 2023
@lordrip lordrip added this to the 0.2.0 - Next step milestone Sep 4, 2023
igarashitm referenced this issue in igarashitm/kaoto Sep 19, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
f30e02e 
Fixes: #8
@igarashitm igarashitm mentioned this issue Sep 20, 2023
Closed
@lhein lhein moved this to Backlog in Kanban Board Sep 21, 2023
@lhein lhein moved this from Backlog to Todo in Kanban Board Sep 21, 2023
@lhein lhein moved this from Todo to In Progress in Kanban Board Sep 21, 2023
igarashitm referenced this issue in igarashitm/kaoto Sep 22, 2023
@igarashitm
fix: Let UI use maven generated YAML DSL sub schema
217670b 
Fixes: KaotoIO#147

ATM sub schemas are not used by UI. We'll soon use for Beans editor (#8) and will be easier to identify the sub schema by its name being same as the property name - for example, `beans` to be a name for the beans sub schema. The old verbose name were moved as `description` in the index.json.
We might want to generate an enum of these sub schema names and put in .d.ts.
@igarashitm igarashitm mentioned this issue Sep 22, 2023
Merged
igarashitm referenced this issue in igarashitm/kaoto Sep 22, 2023
@igarashitm
fix: Let UI use maven generated YAML DSL sub schema
d23e74a 
Fixes: KaotoIO#147

ATM sub schemas are not used by UI. We'll soon use for Beans editor (#8) and will be easier to identify the sub schema by its name being same as the property name - for example, `beans` to be a name for the beans sub schema. The old verbose name were moved as `description` in the index.json.
We might want to generate an enum of these sub schema names and put in .d.ts.
lordrip pushed a commit that referenced this issue Sep 23, 2023
@igarashitm @lordrip
fix: Let UI use maven generated YAML DSL sub schema
66bdd77 
Fixes: #147

ATM sub schemas are not used by UI. We'll soon use for Beans editor (#8) and will be easier to identify the sub schema by its name being same as the property name - for example, `beans` to be a name for the beans sub schema. The old verbose name were moved as `description` in the index.json.
We might want to generate an enum of these sub schema names and put in .d.ts.
igarashitm referenced this issue in igarashitm/kaoto Sep 25, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
d59e459 
Fixes: #8
@igarashitm
Copy link
Contributor Author

I started from copying files from kaoto-ui and hit an import error on uniforms .js file

"default" is not exported by "../uniforms-patternfly/dist/cjs/wrapField.js", imported by "src/components/MetadataEditor/PropertiesField.tsx".
file: /home/toigaras/workspace/Kaoto/kaoto-next/packages/ui/src/components/MetadataEditor/PropertiesField.tsx:3:7
1: import { AddPropertyButtons } from './AddPropertyButtons';
2: import { PropertyRow } from './PropertyRow';
3: import wrapField from '@kaoto-next/uniforms-patternfly/dist/cjs/wrapField';
          ^
4: import { EmptyState, EmptyStateBody, Stack, StackItem } from '@patternfly/react-core';
5: import {
error during build:
RollupError: "default" is not exported by "../uniforms-patternfly/dist/cjs/wrapField.js", imported by "src/components/MetadataEditor/PropertiesField.tsx".
    at error (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:2287:30)
    at Module.error (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:13716:16)
    at Module.traceVariable (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:14146:29)
    at ModuleScope.findVariable (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:12589:39)
    at FunctionScope.findVariable (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:7124:38)
    at ChildScope.findVariable (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:7124:38)
    at Identifier.bind (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:8309:40)
    at CallExpression.bind (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:5892:23)
    at CallExpression.bind (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:9875:15)
    at ReturnStatement.bind (file:///home/toigaras/workspace/Kaoto/kaoto-next/node_modules/rollup/dist/es/shared/node-entry.js:5892:23)

It's here in the code - igarashitm@d59e459#diff-11b0615911fef30b63d0671102541f9c6e13b7d0ff2271e0a04cbe1fef22d80cR3

@lordrip does it ring your bell? it works in kaoto-ui, not sure what's different.

@igarashitm
Copy link
Contributor Author

nevermind, it just needs to use from esm instead.

@lordrip
Copy link
Member

lordrip commented Sep 26, 2023

Did that happened when using import wrapField from '@kaoto-next/uniforms-patternfly' directly?

@lordrip
Copy link
Member

lordrip commented Sep 26, 2023

if we need access to wrapField, we could add the following line to the index.ts file:

export { default as wrapField } from "./wrapField";

@lhein lhein modified the milestones: 0.2.0 - Feature Parity, 0.1.0 - Smart Connectors' MVP Sep 26, 2023
igarashitm referenced this issue in igarashitm/kaoto Sep 28, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
e2897d1 
Fixes: #8
igarashitm referenced this issue in igarashitm/kaoto Sep 28, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
b641e8b 
Fixes: #8
@igarashitm igarashitm mentioned this issue Sep 28, 2023
Merged
igarashitm referenced this issue in igarashitm/kaoto Sep 28, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
abd8ee2 
Fixes: #8
igarashitm referenced this issue in igarashitm/kaoto Sep 28, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
0396276 
Fixes: #8
igarashitm referenced this issue in igarashitm/kaoto Sep 28, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
77cb8b3 
Fixes: #8
igarashitm referenced this issue in igarashitm/kaoto Sep 28, 2023
@igarashitm
feat(Beans): Port Bean Configuration UI
4b6cc23 
Fixes: #8
lordrip pushed a commit that referenced this issue Oct 2, 2023
@igarashitm @lordrip
feat(Beans): Port Bean Configuration UI
04af8a2 
Fixes: #8
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban Board Oct 2, 2023
@lhein lhein removed this from the Smart Connectors' MVP milestone Nov 2, 2023
@lhein lhein added this to the Feature Parity milestone Nov 2, 2023
apupier pushed a commit to apupier/kaoto-next that referenced this issue Dec 9, 2024
@igarashitm
Merge pull request KaotoIO#8 from KaotoIO/renovate/node-20.x-lockfile
c62b69b 
chore(deps): update dependency @types/node to v20.11.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
None yet
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
Development

Successfully merging a pull request may close this issue.

feat(Beans): Port Bean Configuration UI igarashitm/kaoto
3 participants
@igarashitm @lhein @lordrip