Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Load camel catalog in GitHub pages #105

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Sep 8, 2023

Context

Currently, kaoto-next is being deployed on GitHub pages under the following URL:

https://kaotoio.github.io/kaoto-next/

Since the DEFAULT_CATALOG_PATH is /camel-catalog, kaoto-next tries to load the catalog from:

https://kaotoio.github.io/

Changes

The fix is to provide an initial . to instruct to download the catalog under the current location

Relates to: #109

Currently, kaoto-next is being deployed in GitHub pages under
the following URL:

https://kaotoio.github.io/kaoto-next/

Since the `DEFAULT_CATALOG_PATH` is `/camel-catalog`, kaoto-next
tries to load the catalog from:

https://kaotoio.github.io/

The fix is to provide an initial `.` to instruct to download the
catalog under the current location
@lordrip lordrip requested a review from a team September 8, 2023 11:06
@lordrip lordrip merged commit 144a741 into KaotoIO:main Sep 8, 2023
@lordrip lordrip deleted the fix/catalog-load-gh-pages branch September 8, 2023 11:12
@lhein lhein added this to the 0.1.0 - Smart Connectors' MVP milestone Sep 21, 2023
@lhein lhein modified the milestones: Smart Connectors' MVP, Feature Parity Nov 2, 2023
lordrip pushed a commit to lordrip/kaoto that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants