Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1108): Provide common expression result types #1202

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(1108): Provide common expression result types #1202

merged 1 commit into from
Jul 22, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jun 25, 2024

fixes #1108

@tplevko tplevko force-pushed the issue_1108 branch 4 times, most recently from 6256e2a to 93fe9f3 Compare June 26, 2024 07:25
@tplevko tplevko marked this pull request as ready for review June 26, 2024 07:48
@tplevko tplevko marked this pull request as draft June 26, 2024 07:49
@tplevko tplevko marked this pull request as ready for review July 22, 2024 13:21
@tplevko
Copy link
Contributor Author

tplevko commented Jul 22, 2024

Result type typeahead selection:
Screenshot from 2024-07-22 15-22-20

lordrip
lordrip approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @tplevko. I thought of adding these values by default on the typeahead component, as prepopulated items, but I think updating the schema could work as well.

@lordrip lordrip merged commit 2aea10f into KaotoIO:main Jul 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide common Result Types
2 participants
@tplevko @lordrip