Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(form): Introduce a 'User Modified' from section #1252

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat(form): Introduce a 'User Modified' from section #1252

merged 1 commit into from
Jul 25, 2024

Conversation

shivamG640
Copy link
Contributor

Fixes #1129

@shivamG640 shivamG640 force-pushed the Feat1129 branch 4 times, most recently from ebebe6a to cb74001 Compare July 22, 2024 16:04
@shivamG640
Copy link
Contributor Author

shivamG640 commented Jul 22, 2024 •
edited
Loading

Hi @lordrip,
I managed to add the following changes since the Last review:

  • Tests for the newly added util functions.
  • Moved existing tests to the CanvasFormTabs component and added new one for the Tab modes features.
  • Handled DataFormat and similar fields: If a dataformat value is selected, then the whole editor will be visible under the user-Modified tab. (Not sure if I used the right logic for it, Kindly check!)

Please test the latest changes here: https://shivamg640.github.io/kaoto/

@shivamG640 shivamG640 marked this pull request as draft July 22, 2024 16:10
@lordrip
Copy link
Member

lordrip commented Jul 22, 2024

Good progress @shivamG640, I think we're moving in the right direction 🚀

@shivamG640
Copy link
Contributor Author

@lordrip Thanks for the review!
Added all the suggested changes but now I am confused with the next plan?
Are we going to push it to the main branch or we need to work on implementing the same functionality on Dataformat Editor and similar Editors?

@shivamG640 shivamG640 requested a review from lordrip July 22, 2024 20:30
@shivamG640 shivamG640 force-pushed the Feat1129 branch 3 times, most recently from 2e21542 to 159380f Compare July 23, 2024 21:58
@shivamG640 shivamG640 marked this pull request as ready for review July 24, 2024 08:09
@lordrip
Copy link
Member

lordrip commented Jul 24, 2024

@shivamG640, the ExpressionEditor and the DataFormat editor stories need to be updated because at the moment they are not showing the editors. I think it's just a matter of adding the set to the ALL mode.

@shivamG640 shivamG640 force-pushed the Feat1129 branch 5 times, most recently from 71e64c4 to 38ba1ed Compare July 24, 2024 20:22
@lordrip
Copy link
Member

lordrip commented Jul 25, 2024

The PR looks good, thanks for taking care @shivamG640, let's check the issue around setHeadersand I think we're good to go

lordrip
lordrip reviewed Jul 25, 2024
View reviewed changes
packages/ui/src/components/Form/expression/expression.service.ts
@@ -72,9 +73,10 @@ export class ExpressionService {
language: ICamelLanguageDefinition | undefined;
model: Record<string, unknown> | undefined;
} {
if (!isDefined(parentModel)) return { language: undefined, model: undefined };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was added due to a bug when handling the setHeaders EIP, that caused the newly added header to be null, creating an error in the CanvasForm component

@lordrip lordrip merged commit 1d6e57d into KaotoIO:main Jul 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce a new config form section / group "User Modified"
2 participants
@shivamG640 @lordrip