chore(viz): Remove getBaseEntity() method form IVisualizationNode
#1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
chore/remove-getbaseentity
branch
from
3f7b6a1 to
a55c11c
Compare
lordrip
changed the title
getBaseEntity() method form IVisualizationNode
4 tasks
lhein
force-pushed
the
chore/remove-getbaseentity
branch
from
a55c11c to
7faeb0f
Compare
igarashitm
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR removes the
getBaseEntity()method from theIVisualizationNodewith the objective of walking towards nodes containing all the information needed to render themselves.fix: #1329