Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e - add side panel required filter field coverage #1340

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Aug 20, 2024

No description provided.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@68a9f66). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1340   +/-   ##
=======================================
  Coverage        ?   67.32%           
  Complexity      ?       25           
=======================================
  Files           ?      264           
  Lines           ?     7588           
  Branches        ?     1515           
=======================================
  Hits            ?     5109           
  Misses          ?     2422           
  Partials        ?       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tplevko tplevko marked this pull request as ready for review August 21, 2024 06:28
@tplevko
Copy link
Contributor Author

tplevko commented Aug 21, 2024

I'm afraid that the code duplication reported by the SonarCloud code analysis is a feature of Cypress tests.

@lordrip lordrip merged commit 4b7dfa4 into KaotoIO:main Aug 21, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants