Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1422) Config panel buttons overlay - add toggleGroup wrapping #1427

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix(1422) Config panel buttons overlay - add toggleGroup wrapping #1427

merged 2 commits into from
Sep 12, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Sep 11, 2024 •
edited by lordrip
Loading

apupier
apupier reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine in VS Code too.
some style lint to fix though (failing the build)

@tplevko tplevko force-pushed the issue_1422 branch 2 times, most recently from ad1e39d to c481700 Compare September 11, 2024 10:23
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fe5d257). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1427   +/-   ##
=======================================
  Coverage        ?   67.52%           
  Complexity      ?       25           
=======================================
  Files           ?      266           
  Lines           ?     7600           
  Branches        ?     1482           
=======================================
  Hits            ?     5132           
  Misses          ?     2465           
  Partials        ?        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tplevko tplevko marked this pull request as ready for review September 11, 2024 12:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lordrip
lordrip approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tplevko

@lordrip lordrip merged commit ab413a2 into KaotoIO:main Sep 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apupier apupier apupier left review comments

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config panel buttons All is overlayed when the config panel is relatively small
4 participants
@tplevko @apupier @lordrip @lhein