chore(Tests): Split form-related tests #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have 3 that take a long time due to their nature. Each of these tests takes one catalog category and renders the configuration form for each of them. While this works, the penalty is that we block jest worker nodes (threads) so the tests are pinned to a single worker without any chance of splitting the work, making the test slow. This commit splits them into smaller sections, so the tests are better distributed among all available worker nodes (threads). Comparison: * No split ``` Time: 109.227 s Time: 143.646 s ``` * Split ``` Time: 23.485 s Time: 24.143 s ```
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
=======================================
Coverage ? 68.76%
Complexity ? 25
=======================================
Files ? 271
Lines ? 7753
Branches ? 1524
=======================================
Hits ? 5331
Misses ? 2373
Partials ? 49 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, we have 3 that take a long time due to their nature. Each of these tests takes one catalog category and renders the configuration form for each of them.
While this works, the penalty is that we block jest worker nodes (threads) so the tests are pinned to a single worker without any chance of splitting the work, making the test slow.
This commit splits them into smaller sections, so the tests are better distributed among all available worker nodes (threads).
Comparison:
CI comparison
Screenshots
No split
Split
You can also notice that we can use more threads due to this split.
Single thread (no split)
Multiple threads (split)