-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading of Red Hat artifacts for catalog #1645
Fix loading of Red Hat artifacts for catalog #1645
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1645 +/- ##
=======================================
Coverage ? 83.98%
Complexity ? 365
=======================================
Files ? 284
Lines ? 8147
Branches ? 1605
=======================================
Hits ? 6842
Misses ? 1217
Partials ? 88 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
28a83d4
to
10d5599
Compare
I think the reason it works with the test and not from command-line is that camel-yaml-dsl artifact is part of the test dependencies, consequently the schema/camelYamlDsl.json is always picked from this one and not from what is loaded dynamically |
io.kaoto.camelcatalog.maven.CamelCatalogVersionLoader.configureRepositories(String) is called too late for Camel Yaml DSL loading. it is called when loading Camel Catalogs. |
io.kaoto.camelcatalog.maven.CamelCatalogVersionLoader.configureRepositories(String) is called too late for Camel Yaml DSL loading. it is called when loading Camel Catalogs. Quickfix provided: calling the CamelCatalog which is configuring the repositories at first not perfect as note all versions are aligned and some others might need it but should be enough to unblock current situation note that the provided is not efficient because the camel-yaml-dsl test dependency is leaking in the other tests, thus even without the fix the test is passing... I guess it would require to create a separate module for the test or to ensure a specific version is picked (see also next paragraph) Another note: when several catalog are generated at same time, I'm not sure that we can ensure that it picks the exact correct version of the camel-yaml-dsl, it might be the first one found, whatever version it is; To be checked. In practice I think that most of the time there are no differences. fixes KaotoIO#1597 Signed-off-by: Aurélien Pupier <[email protected]>
10d5599
to
5c2d1c6
Compare
Quality Gate passedIssues Measures |
io.kaoto.camelcatalog.maven.CamelCatalogVersionLoader.configureRepositories(String) note that the provided is not efficient because the camel-yaml-dsl test Another note: when several catalog are generated at same time, I'm not |
the test is passing locally for me despite i checked settings.xml to not have the red hat maven repoitory and remove the org.apache/camel folder from my .m2 so maybe another specific part is failing?
relates to #1597