fix(Build): Run Kaoto in Windows #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, dev mode is broken in Windows since the `vite.config.js` file is not copying the catalog files properly. In addition to that, the files path are generated using the underlying OS path separator. The fix is to use the `normalizePath` function from `vite`, so it uses a linux-like path to copy the files. From the Catalog generator part, it forces to use the `/` as path separator, so it loads properly in the browser. fix: KaotoIO#1654
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
=======================================
Coverage ? 84.07%
Complexity ? 365
=======================================
Files ? 285
Lines ? 8161
Branches ? 1573
=======================================
Hits ? 6861
Misses ? 1211
Partials ? 89 ☔ View full report in Codecov by Sentry. |
lhein
reviewed
Dec 3, 2024
packages/catalog-generator/src/main/java/io/kaoto/camelcatalog/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
lordrip
commented
Dec 3, 2024
packages/catalog-generator/src/main/java/io/kaoto/camelcatalog/commands/GenerateCommand.java
Outdated
Show resolved
Hide resolved
…/commands/GenerateCommand.java
|
lhein
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, dev mode is broken in Windows since the
vite.config.jsfile is not copying the catalog files properly. In addition to that, the file paths are generated using the underlying OS path separator.Changes
The fix is to use the
normalizePathfunction fromvite, so it uses a Linux-like path to copy the files. From the Catalog generator part, it forces the use of the/as a path separator so it loads properly in the browser.fix: #1654