Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 4.9.0 to Catalog for Main and Spring Boot #1691

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

apupier
Copy link
Member

@apupier apupier commented Dec 4, 2024

wondering if we should wait for Camel Kamelet and Camel Quarkus aligned with that too.

belongs to #1695

@apupier
Copy link
Member Author

apupier commented Dec 4, 2024

a bunch of tests to adjust (and to verify it is just a matter of adjusting to new version and not a regression):

[@kaoto/kaoto]: Tests:       9 failed, 1 skipped, 2 todo, 1325 passed, 1337 total
[@kaoto/kaoto]: Snapshots:   7 failed, 134 passed, 141 total

@oscerd
Copy link
Contributor

oscerd commented Dec 4, 2024

Camel Kamelets 4.9.0 is on vote.

@apupier apupier added this to the 2.4.0 milestone Dec 4, 2024
@lordrip
Copy link
Member

lordrip commented Dec 4, 2024

There are snapshots broken due to new parameters in some EIPs and the dataformat test is broken probably due to a new one being included.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d14e4c0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage        ?   84.32%           
  Complexity      ?      365           
=======================================
  Files           ?      287           
  Lines           ?     8208           
  Branches        ?     1629           
=======================================
  Hits            ?     6921           
  Misses          ?     1198           
  Partials        ?       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apupier apupier force-pushed the include4.9.0InCatalogSet branch from c43545b to ee67658 Compare December 6, 2024 08:34
Copy link
Contributor

@lhein lhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@apupier apupier force-pushed the include4.9.0InCatalogSet branch from ee67658 to e1a421d Compare December 6, 2024 09:44
@lhein lhein modified the milestones: 2.4.0, 2.3.0 Dec 6, 2024
@apupier apupier force-pushed the include4.9.0InCatalogSet branch from e1a421d to 428336e Compare December 6, 2024 12:37
@lhein
Copy link
Contributor

lhein commented Dec 8, 2024

Quarkus version still to be changed.

@lhein lhein marked this pull request as ready for review December 8, 2024 18:01
@lordrip lordrip marked this pull request as draft December 9, 2024 08:05
@apupier apupier force-pushed the include4.9.0InCatalogSet branch from 428336e to e4e2e8c Compare December 9, 2024 08:06
@apupier apupier force-pushed the include4.9.0InCatalogSet branch from e4e2e8c to 7afe558 Compare December 9, 2024 08:38
Copy link

sonarcloud bot commented Dec 9, 2024

@lordrip lordrip marked this pull request as ready for review December 9, 2024 09:06
@lordrip lordrip merged commit 3e77017 into KaotoIO:main Dec 9, 2024
14 checks passed
@apupier apupier deleted the include4.9.0InCatalogSet branch December 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants