Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viz) Replace Camel Route steps #288

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Nov 3, 2023

Context

At this moment, only CamelK Pipes supports node insite replacement.
The goal for this pull request is to add said functionality for Camel Routes as well.

Changes

  • When removing the from node from a Camel Route, it gets replaced with a placeholder, like the source and sink nodes from CamelK Pipe
    image

  • When replacing the from node from a Camel Route, the catalog only shows components that don't contain the producerOnly tag.
    image

@lordrip lordrip requested a review from a team November 3, 2023 11:55
@lordrip lordrip linked an issue Nov 3, 2023 that may be closed by this pull request
Currently, only CamelK Pipes support to replace nodes, leveraging
source and sink placeholders.

This commit adds the same functionality for Camel Routes

fix: KaotoIO#79
@lordrip lordrip force-pushed the feat/replace-camel-route-step branch from a279812 to f958886 Compare November 3, 2023 12:04
@lordrip lordrip merged commit bd38797 into KaotoIO:main Nov 3, 2023
10 checks passed
@lordrip lordrip deleted the feat/replace-camel-route-step branch November 10, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace existing nodes with a different one
2 participants