fix(catalog): Avoid offering already existing single properties. #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Context For some Processors like `Choice` and `DoTry`, there are properties that could contain nested processors. In case of `Choice`, it's the `otherwise` property. * Changes This commit check what's already defined in the `Processor` to avoid offering it again since it might cause data loss. Fixes: KaotoIO#334
lordrip
force-pushed
the
fix/avoid-offer-existing-single-properties
branch
from
c456ecb to
9cee228
Compare
apupier
approved these changes
Nov 22, 2023
tplevko
reviewed
Nov 22, 2023
Comment on lines
+119
to
+120
| if (!definitionKeys.includes('doTry')) { | ||
| specialChildren.doTry.push('doTry'); |
There was a problem hiding this comment.
Shouldn't there be specified "doFinally"?
There was a problem hiding this comment.
You're right @tplevko, thanks for catching this up, I'll create another pull request to fix this.
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Nov 22, 2023
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Nov 22, 2023
lordrip
added a commit
that referenced
this pull request
Nov 22, 2023
Follow up of: #398 (comment) Fixes: #334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For some Processors like
ChoiceandDoTry, there are properties that could contain nested processors. In case ofChoice, it's theotherwiseproperty.Changes
This pull request checks what's already defined in the
Processorto avoid offering it again since it might cause data loss.Screencast
Screencast.from.2023-11-22.15-22-23.webm
Fixes: #334