Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltips for each step on the canvas #629

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Jan 12, 2024

These changes will bring tooltips for each step on the canvas.
Fixes #538

@shivamG640
Copy link
Contributor Author

Hi @lordrip ,
I added the changes we discussed yesterday and made it show the schema description(component name as fallback). Let me know what you think!
I am still working on the tests and will add them soon!

@lordrip
Copy link
Member

lordrip commented Jan 22, 2024

Hi @shivamG640, tried your branch locally and I think you're on the right track. Just for information, there are a few cases that you need to consider:

  • Processors: log, choice, doTry, etc
  • Processors that reference components: from, to, toD, in this case, we need to show the component's description instead
  • Kamalets: We need to show kamelets' descriptions

You'll notice what are you working with by inspecting whether you have a componentName in the component lookup or not

@shivamG640 shivamG640 marked this pull request as ready for review January 23, 2024 13:00
@shivamG640 shivamG640 requested a review from lordrip January 23, 2024 13:00
@shivamG640
Copy link
Contributor Author

Hi @lordrip ,
I've updated the code as per your comments. Let me know if I can help you in reviewing by sharing my screen instead of you running my repo locally!

@shivamG640
Copy link
Contributor Author

@lordrip ,
Thanks for identifying the missing tooltip functionality for kamelets. This task can be marked as completed now. Let me know your thoughts on it!

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally and it works great 🎉 , thanks @shivamG640 for this.

Regarding to the comments, please feel free to address them in an upcoming PR so we don't delay this one 😃


return content;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please create an issue for adding a test case for this? There are similar test cases that you could get inspiration from.

@lhein lhein added the rebase This PR branch is out of date and needs a rebase. label Jan 25, 2024
@lordrip lordrip merged commit 2c3c995 into KaotoIO:main Jan 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebase This PR branch is out of date and needs a rebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show tooltips for each step on the canvas
4 participants