Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Gain space for the editor in VS Code #817

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

apupier
Copy link
Member

@apupier apupier commented Feb 8, 2024

part of KaotoIO/vscode-kaoto#465

with this PR:
image

so compared to before, we gain space related to highlighted in the color red, dark blue and a part of purple and light blue with this PR:
image

@apupier apupier marked this pull request as ready for review February 8, 2024 14:57
@apupier apupier requested a review from a team February 8, 2024 14:57
@apupier apupier merged commit b9b5c3d into KaotoIO:main Feb 9, 2024
9 checks passed
@apupier apupier deleted the vscode-465-gainSpace branch February 9, 2024 09:16
@lordrip
Copy link
Member

lordrip commented Feb 9, 2024

There's an issue with the Metadata part:
image

@apupier
Copy link
Member Author

apupier commented Feb 9, 2024

This is unrelated to this PR, I reproduce with released version.
I think it has always been displayed like that (at least in VS Code)

@apupier
Copy link
Member Author

apupier commented Feb 9, 2024

This is unrelated to this PR, I reproduce with released version.
I think it has always been displayed like that (at least in VS Code)

my bad, there is a slight difference with left padding

@apupier
Copy link
Member Author

apupier commented Feb 9, 2024

provided a fix with this PR #821

@apupier apupier linked an issue Feb 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gain space for the editor
3 participants