feat(restConfiguration): Add restConfiguration entity #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for RestConfiguration entity. Note: The node validation is still pending due to an issue with the JSONSchema, please see KaotoIO#969 for more details. fix: KaotoIO#562 relates: KaotoIO#969
lordrip
force-pushed
the
feat/add-rest-configuration
branch
from
519933e to
25cadfa
Compare
lordrip
commented
Mar 21, 2024
| const ajv = new Ajv({ | ||
| strict: false, | ||
| allErrors: true, | ||
| useDefaults: 'empty', |
There was a problem hiding this comment.
@igarashitm , I think you already saw this, but in any case, this useDefaults: 'empty' causes us to write all default values in the model, and since we don't want that, I'm validating a copy of the model, so the original don't get updated.
lordrip
commented
Mar 21, 2024
| type: 'boolean', | ||
| title: 'Use XForward Headers', | ||
| description: 'Whether to use X-Forward headers for Host and related setting. The default value is true.', | ||
| default: true, |
There was a problem hiding this comment.
This is the right default value
lordrip
commented
Mar 21, 2024
Comment on lines
+142
to
+185
| /** Skip until https://github.com/KaotoIO/kaoto-next/issues/969 gets resolved */ | ||
| describe.skip('getNodeValidationText', () => { | ||
| it('should return undefined for valid definitions', () => { | ||
| const entity = new CamelRestConfigurationVisualEntity({ | ||
| restConfiguration: { | ||
| ...restConfigurationDef.restConfiguration, | ||
| useXForwardHeaders: true, | ||
| apiVendorExtension: true, | ||
| skipBindingOnErrorCode: true, | ||
| clientRequestValidation: true, | ||
| enableCORS: true, | ||
| enableNoContentResponse: true, | ||
| inlineRoutes: true, | ||
| }, | ||
| }); | ||
|
|
||
| expect(entity.getNodeValidationText()).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('should not modify the original definition when validating', () => { | ||
| const originalRestConfigurationDef: RestConfiguration = { ...restConfigurationDef.restConfiguration }; | ||
| const entity = new CamelRestConfigurationVisualEntity(restConfigurationDef); | ||
|
|
||
| entity.getNodeValidationText(); | ||
|
|
||
| expect(restConfigurationDef.restConfiguration).toEqual(originalRestConfigurationDef); | ||
| }); | ||
|
|
||
| it('should return errors when there is an invalid property', () => { | ||
| const invalidRestConfigurationDef: RestConfiguration = { | ||
| ...restConfigurationDef.restConfiguration, | ||
| bindingMode: 'WildModeOn' as RestConfiguration['bindingMode'], | ||
| }; | ||
| const entity = new CamelRestConfigurationVisualEntity({ restConfiguration: invalidRestConfigurationDef }); | ||
|
|
||
| expect(entity.getNodeValidationText()).toEqual(`'/useXForwardHeaders' must be boolean, | ||
| '/apiVendorExtension' must be boolean, | ||
| '/skipBindingOnErrorCode' must be boolean, | ||
| '/clientRequestValidation' must be boolean, | ||
| '/enableCORS' must be boolean, | ||
| '/enableNoContentResponse' must be boolean, | ||
| '/inlineRoutes' must be boolean`); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
We need to reenable this test, once #969 is fixed.
lordrip
commented
Mar 21, 2024
Comment on lines
+87
to
+91
| it.skip('should return schema from store', () => { | ||
| const entity = new CamelRestConfigurationVisualEntity(restConfigurationDef); | ||
|
|
||
| expect(entity.getComponentSchema().schema).toEqual(restConfigurationSchema); | ||
| }); |
There was a problem hiding this comment.
We need to reenable this test, once #969 is fixed.
igarashitm
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This commit adds support for the
RestConfigurationentity.How to test
Screenshot
Note:
The node validation is still pending due to an issue with the JSONSchema, please see #969 for more details.
fix: #562
relates: #969