fix(code): Use YAML 1.1 for serializing #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Kaoto serialize to YAML using YAML 1.2. This creates an edge for the Rest component since one of its parameters (`bindingMode`) accepts an `off` value which ultimately gets serialized as it is, causing to be interpreted as `false`. This commit change the YAML serializing schema to 1.1 so `off` gets serialized as `"off"` avoiding this issue. fix: KaotoIO#971
igarashitm
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, Kaoto serializes to YAML using YAML 1.2.
This creates an edge for the Rest component since one of its parameters (
bindingMode) accepts anoffvalue which ultimately gets serialized as it is, causing it to be interpreted asfalse.This commit changes the YAML serializing schema to 1.1 so
offgets serialized as"off"avoiding this issue.fix: #971