fix(Settings): Use default Settings from Kaoto #709
Conversation
The failures are likely due to the changes in the canvas nodes, I'll check |
lordrip
force-pushed
the
fix/use-default-settings
branch
from
d4ffe5e to
01aea66
Compare
it-tests/BasicFlow.test.ts
Outdated
| until.elementLocated(By.css('g[data-testid^="custom-node__timer"]')) | ||
| ); | ||
| const threeDotsIconOfOneOfTheSteps = (await driver.findElements(By.xpath('//*[@data-type="node"]//*[@class="pf-topology__node__action-icon"]')))[1]; | ||
| await threeDotsIconOfOneOfTheSteps.click(); | ||
|
|
||
| const canvasNode = await driver.findElement(By.css('g[data-testid^="custom-node__timer"]')); | ||
| driver.actions().contextClick(canvasNode).perform(); |
There was a problem hiding this comment.
Since the 3-dots button is no longer there, we're triggering a right-click event over the node to get the same menu.
There was a problem hiding this comment.
just a small one for the stabillity.. is the "driver.actions...perform()" a floating Promise? I think we could missing 'await' here
There was a problem hiding this comment.
I don't know, I'll check
There was a problem hiding this comment.
Alrighty, I was missing the await, perform is certainly a Promise, thanks for the catch @djelinek
| timer: By.xpath(`//\*[name()='g' and starts-with(@data-id,'timer')]`), | ||
| label: By.xpath(`//\*[name()='g' and starts-with(@class,'pf-topology__node__label')]`) | ||
| timer: `g[data-id^='timer'][data-kind='node']`, | ||
| label: `.custom-node__label`, |
There was a problem hiding this comment.
This selector changed because there's no more topology label but rather a standard text.
| @@ -64,7 +64,7 @@ describe('User Settings', function () { | |||
| it(`Check 'id' Node Label is used instead of default 'description'`, async function () { | |||
| this.timeout(60_000); | |||
|
|
|||
| const timer = await driver.findElement(locators.TimerComponent.timer).findElement(locators.TimerComponent.label); | |||
| const timer = await driver.findElement(By.css(`${locators.TimerComponent.timer} ${locators.TimerComponent.label}`)); | |||
There was a problem hiding this comment.
Semantically, this is not exactly the same as before.
Before, we were locating a node and from that point, we searched for another one within. Now, we're targeting the label that is inside of the node.
The issue is that for some reason, topology now creates invisible nodes, potentially as references inside of the groups, so it means the test library finds 2 nodes, instead of one, and the first one is empty, therefore, the location fails.
From Kaoto side, we have default settings in the [settings.model.ts](https://github.com/KaotoIO/kaoto/blob/9ee3368e0e488853f61a84fa4e16bedadc801fda/packages/ui/src/models/settings/settings.model.ts#L23-L25) file. This commit uses that and only override what needs to be changed in terms of the `catalogUrl` and the `nodeLabel`. Once the VS Code setting for the new property `nodeToolbarTrigger` is merged, we can add it also to the VS Code settings object.
lordrip
force-pushed
the
fix/use-default-settings
branch
from
01aea66 to
35baa2f
Compare
|
Context
From the Kaoto side, we have default settings in the
settings.model.ts file.
Changes
This commit uses that and only overrides what needs to be changed in terms of the
catalogUrland thenodeLabel.Notes
Once the VS Code setting for the new property
nodeToolbarTriggeris merged, we can add it also to the VS Code settings object.