fix: add reply button selector for text button labels mode (#738) #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the slow response. Work at work, Christmas at home, illness everywhere, etc. I've just tested this fix and confirm it fixes the original issue without creating any regressions as far as I can see. If you'd like for me to create a new release for this, feel free to update CHANGELOG.md to include your bugfix too, before I merge 😄 |
|
Old PR is old. Closing. Re-open and let me know if you still want this added. |
|
Hello, this issue is still valid and we still have a workaround for it in our code (overriding gmail-js function with our own). 🙂 Consider reopening and merging. |
|
I'm open to merging, but I requested specific changes first. See above 🙂 Get those done and we'll get this closed proper. |
|
Updated |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.