Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target 30 support #404

Closed
AzamatCherchesov opened this issue Nov 2, 2022 · 3 comments
Closed

Target 30 support #404

AzamatCherchesov opened this issue Nov 2, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@AzamatCherchesov
Copy link
Collaborator

AzamatCherchesov commented Nov 2, 2022

Correct work with storage (migrate from Manage all external storage permission to Scoped storage)

@AzamatCherchesov AzamatCherchesov added the enhancement New feature or request label Nov 2, 2022
@AzamatCherchesov AzamatCherchesov added this to the Improved screenshots milestone Nov 2, 2022
@Nikitae57
Copy link
Collaborator

Nikitae57 commented Nov 7, 2022

Need to be careful with this. Whole kaspresso is built on using traditional file API.

Screen recording on Android 10+

  • Current implementation uses "abd shell screenrecord path/to/save/video/on/device" (I'll call it just screen recorder onwards).
  • screen recorder could write video to /sdcard/ but we can't create any subfolders from kaspresso without MANAGE_EXTERNAL_STORAGE permission
  • screen recorder can't record to /data/data/your.package/files directory because of permissions issue

Allure

We need to be able to include video recordings to allure reports. Allure reports are stored under /data/data directory. AFAIK, we can't configure allure reports path

Screenshoting

  • Screenshots are organized in a special dirs structure. Ideally we need to be able to preserve it. I wouldn't consider using long file names and flat files structure. Android restricts file name length to 255 characters
  • Additionally to screenshots XML metadata is stored alongside them

Useful info: https://medium.com/androiddevelopers/scope-storage-myths-ca6a97d7ff37

@Nikitae57 Nikitae57 assigned Nikitae57 and unassigned Areyana Nov 9, 2022
@Nikitae57
Copy link
Collaborator

Linked to #407

@Nikitae57
Copy link
Collaborator

We discussed the idea to put all artifacts into Documents folder since it's a public folder and quick experiment showed us that we could use it without restrictions. With this approach we have to keep in mind that allure stores reports to /data/data. Ideally we want to save reports to the same place as other artifacts. We decided that we'll copy reports from /data/data to Documents and cover it with an optional flag in Kaspresso builder

Nikitae57 added a commit that referenced this issue Nov 15, 2022
Nikitae57 added a commit that referenced this issue Nov 17, 2022
Nikitae57 added a commit that referenced this issue Nov 17, 2022
Nikitae57 added a commit that referenced this issue Nov 21, 2022
Nikitae57 added a commit that referenced this issue Nov 22, 2022
Nikitae57 added a commit that referenced this issue Nov 22, 2022
Nikitae57 added a commit that referenced this issue Nov 23, 2022
Nikitae57 added a commit that referenced this issue Nov 30, 2022
Nikitae57 added a commit that referenced this issue Dec 1, 2022
…tion to get run notifier from instrumentation
AzamatCherchesov added a commit that referenced this issue Dec 1, 2022
…estrictions

#404: Using documents to avoid storage restrictions
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
eakurnikov pushed a commit that referenced this issue Dec 2, 2022
…tion to get run notifier from instrumentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants