Issue/242-3 #286

matzuk · 2021-10-05T11:36:51Z

Hi @sergio-sastre!
Again, thank you very much for your contribution. You've done a great job!
So, I spent some time thinking about how to make Robololectric support more seamless for users. I've decided to evolve your solution in the following things:

A user doesn't need to add sharedTest = true. All tests can be run on the JVM environment and Instrumental environment simultaneously without additional configurations (except Robolectric configuration sure). With the previous solution, reusage of the test on both environments was a little bit trickier.
KautomatorConfig is transformed into InstrumentalDepsAssistant and related classes. It allows to reduce boilerplate code and leave some Device classes and methods working even on the JVM environment.
A user can know and use the environment state through isInstrumentalEnvironment property in TestContext and Kaspresso.Builder classes.
All manipulations with inteceptors are living inside Kaspresso class. But, a user can do similar things in Kaspresso.Builder too.

The tests do run successfully on the emulator but not on the JVM yet. We still need to separate the Kautomator config to make it possible

Was also necessary to downgrade the version of androidXCore to avoid gradle error (was including different versions of the same dependencies, making gradle fail when running the tests on the JVM)

It is the class that decides how to initialize the Kautomator dependent classes, since Robolectric does not support UiAutomator -> Kautomator

This text contains very long text. Therefore, it needs to use the AutoScrollInterceptor to run successfully as Instrumentation as well as JVM test

…he commands

Code review suggestion

update fork

… shared tests

…ts in kaspresso-sample

# Conflicts: # allure-support/src/main/kotlin/com/kaspersky/components/alluresupport/AllureSupportKaspressoBuilder.kt # kaspresso/src/main/kotlin/com/kaspersky/kaspresso/device/accessibility/AccessibilityImpl.kt # kaspresso/src/main/kotlin/com/kaspersky/kaspresso/device/exploit/ExploitImpl.kt # kaspresso/src/main/kotlin/com/kaspersky/kaspresso/device/viewhierarchy/ViewHierarchyDumperImpl.kt # kaspresso/src/main/kotlin/com/kaspersky/kaspresso/kaspresso/Kaspresso.kt

kaspresso/build.gradle.kts

sergio-sastre

@matzuk
Hi there, I got some time to review it! Thanks for the changes!
I like the approach in general, and agree on the sharedTest flag not being needed.

There are 2 points to review:

@RequiresApi(Build.VERSION_CODES.N) for uiAutomation -> unless there is any other reason, it should be @RequiresApi(Build.VERSION_CODES.JELLY_BEAN_MR2), API 18 as stated in the docu
ActivitiesImpl takes instrumentation as argument. Not sure whether it is allowed on the JVM but it could crash in that case?

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/device/activities/ActivitiesImpl.kt

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/instrumental/InstrumentalDepsAssistant.kt

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/instrumental/InstrumentalDepsAssistantImpl.kt

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/instrumental/InstrumentalUtils.kt

.../src/sharedTest/kotlin/com/kaspersky/kaspressample/sharedtest/FailingKautomatorSharedTest.kt

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/instrumental/InstrumentalUtils.kt

kautomator/src/main/kotlin/com/kaspersky/components/kautomator/common/InstrumentalUtils.kt

…dded

… 4.6.1 causes some unexpected crashes in Reflection.

...port/src/main/kotlin/com/kaspersky/components/alluresupport/AllureSupportKaspressoBuilder.kt

kaspresso/build.gradle.kts

RuslanMingaliev · 2021-10-07T21:07:06Z

samples/kaspresso-sample/build.gradle.kts

+        targetCompatibility = JavaVersion.VERSION_1_8
+    }
+
+    kotlinOptions {


And this too

RuslanMingaliev · 2021-10-07T21:08:47Z

samples/kaspresso-sample/build.gradle.kts

@@ -9,8 +9,37 @@ android {
        testInstrumentationRunnerArguments["clearPackageData"] = "true"
    }

+    sourceSets {


should be part of convention.android-base plugin

RuslanMingaliev · 2021-10-07T21:10:53Z

samples/kaspresso-sample/build.gradle.kts

+    testImplementation(libs.androidXTest)
+    testImplementation(libs.robolectric)
+
+    debugImplementation(libs.fragmentTesting)


Using debugImplementation configuration for test dependencies is awful. Do we really need this dependency?

RuslanMingaliev · 2021-10-07T21:12:25Z

samples/kaspresso-sample/build.gradle.kts


    androidTestUtil(libs.orchestrator)
+
+    testImplementation(libs.runner)


Is the AndroidX Test Runner needed for unit tests?

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/instrumental/InstrumentalDepsAssistant.kt

…support/AllureSupportKaspressoBuilder.kt Co-authored-by: Ruslan Mingaliev <[email protected]>

…/InstrumentalDepsAssistantImpl.kt Co-authored-by: Ruslan Mingaliev <[email protected]>

…ed to clean the Unit tests folder

sergio-sastre and others added 27 commits July 13, 2021 20:50

Add dependencies for JVM tests as well as a sharedTest

1e206b7

The tests do run successfully on the emulator but not on the JVM yet. We still need to separate the Kautomator config to make it possible

Update libs.version.toml

68a7ec4

Was also necessary to downgrade the version of androidXCore to avoid gradle error (was including different versions of the same dependencies, making gradle fail when running the tests on the JVM)

Add KautomatorConfig

fabcde1

It is the class that decides how to initialize the Kautomator dependent classes, since Robolectric does not support UiAutomator -> Kautomator

Update Kaspresso to use KautomatorConfig

b23339e

Handle Device? as optional

fc98114

Add Shared test that can run as Instrumentation and JVM test

c2a5edf

This text contains very long text. Therefore, it needs to use the AutoScrollInterceptor to run successfully as Instrumentation as well as JVM test

Update all tests depending on Device since it is optional now

5d5f35c

Rename and restructure SharedTest files

373047e

Add SharedTest documentation to wiki

2863b2b

Better exception message for using Kautomator in sharedTest

35eea62

Remove Nitrogen from the documentation and small docu fix regarding t…

0bef09c

…he commands

Revert Device as Optional -> Device?

09818c8

restructure uiDeviceConfig classes

63853f3

Throw exceptions If using device in shared tests

63499fc

Update docu with error handling

4cc9c1a

Make uiDevice a variable with get()

ef6abc6

Code review suggestion

Merge pull request sergio-sastre#1 from KasperskyLab/master

601239b

update fork

Solve conflicts with allure support

3ae9ad8

Allow take videos/screenshot & dump view hierarchy be compatible with…

edb2c17

… shared tests

Update FailingKautomatorSharedTest.kt

e465fd2

KautomatorInSharedTestException expected only when running on JVM

e4dcac4

issue KasperskyLab#242. Removed duplicated code in kaspresso.gradle

d8e4a6b

issue KasperskyLab#242. Removed needless Kakao dependency for UnitTes…

3063a05

…ts in kaspresso-sample

issue KasperskyLab#242. Robolectric support (version KasperskyLab#3)

d636a4d

issue KasperskyLab#242. Wiki for Robolectric feature

cb613d0

issue KasperskyLab#242. merge

4aa99c4

matzuk requested review from RuslanMingaliev and eakurnikov October 5, 2021 11:36

matzuk mentioned this pull request Oct 5, 2021

#issue242 add robolectric support #267

Merged

RuslanMingaliev reviewed Oct 5, 2021

View reviewed changes

kaspresso/build.gradle.kts Show resolved Hide resolved

sergio-sastre suggested changes Oct 5, 2021

View reviewed changes

matzuk added 11 commits October 7, 2021 05:57

Merge remote-tracking branch 'upstream-2/master' into issue/242-3

c2a55f3

issue KasperskyLab#242. timeout to check flakySafety on the JVM was a…

653974d

…dded

issue KasperskyLab#242. review fixes

9eeaf4d

issue KasperskyLab#242. Environment detector has been refactored

b0d1617

issue KasperskyLab#242. detekt fixes

467feea

issue KasperskyLab#242. detekt fixes 2

bef60ff

issue KasperskyLab#242. detekt fixes 3

cc8a3f9

issue KasperskyLab#242. detekt fixes 4

d87599c

issue KasperskyLab#242. up Robolectric version

b4ecd08

issue KasperskyLab#242. fixed shared tests

0ce918f

issue KasperskyLab#242. rollback Robolectric version to 4.5.1 because…

aa77122

… 4.6.1 causes some unexpected crashes in Reflection.

RuslanMingaliev reviewed Oct 7, 2021

View reviewed changes

matzuk and others added 12 commits October 8, 2021 04:49

Update allure-support/src/main/kotlin/com/kaspersky/components/allure…

b0562a6

…support/AllureSupportKaspressoBuilder.kt Co-authored-by: Ruslan Mingaliev <[email protected]>

Update allure-support/src/main/kotlin/com/kaspersky/components/allure…

e2e6b24

…support/AllureSupportKaspressoBuilder.kt Co-authored-by: Ruslan Mingaliev <[email protected]>

Update allure-support/src/main/kotlin/com/kaspersky/components/allure…

e1dcea5

…support/AllureSupportKaspressoBuilder.kt Co-authored-by: Ruslan Mingaliev <[email protected]>

Update allure-support/src/main/kotlin/com/kaspersky/components/allure…

6da86b0

…support/AllureSupportKaspressoBuilder.kt Co-authored-by: Ruslan Mingaliev <[email protected]>

Update kaspresso/src/main/kotlin/com/kaspersky/kaspresso/instrumental…

4954ce6

…/InstrumentalDepsAssistantImpl.kt Co-authored-by: Ruslan Mingaliev <[email protected]>

issue KasperskyLab#242. Tests checking Robolectric fails were relocat…

9f459ba

…ed to clean the Unit tests folder

issue KasperskyLab#242. Updated tests

575f20e

issue KasperskyLab#242. Generics in InstrumentalDepAssisFactory

0a2366d

issue KasperskyLab#242. Review fixes

c00c58b

issue KasperskyLab#242. isAndroidRuntime is removed from TestContext

2013593

issue KasperskyLab#242. review fixes

2552e7b

issue KasperskyLab#242. review fixes

808dd2d

RuslanMingaliev approved these changes Oct 11, 2021

View reviewed changes

matzuk merged commit 76940bd into KasperskyLab:master Oct 12, 2021

This was referenced Oct 12, 2021

Issue #242 - Add support to write Kaspresso-like tests that run on the JVM with Robolectric #243

Closed

Feature/steps propagation into shell for marathon #165

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue/242-3 #286

Issue/242-3 #286

matzuk commented Oct 5, 2021

sergio-sastre left a comment

RuslanMingaliev Oct 7, 2021

RuslanMingaliev Oct 7, 2021

RuslanMingaliev Oct 7, 2021

RuslanMingaliev Oct 7, 2021


		androidTestUtil(libs.orchestrator)

		testImplementation(libs.runner)

Issue/242-3 #286

Issue/242-3 #286

Conversation

matzuk commented Oct 5, 2021

sergio-sastre left a comment

Choose a reason for hiding this comment

RuslanMingaliev Oct 7, 2021

Choose a reason for hiding this comment

RuslanMingaliev Oct 7, 2021

Choose a reason for hiding this comment

RuslanMingaliev Oct 7, 2021

Choose a reason for hiding this comment

RuslanMingaliev Oct 7, 2021

Choose a reason for hiding this comment