Params fixes #290
Merged
Params fixes #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakurnikov
force-pushed
the
logcat_and_params_fixes
branch
2 times, most recently
from
b46e1a2 to
97eea09
Compare
eakurnikov
force-pushed
the
logcat_and_params_fixes
branch
from
97eea09 to
07a156e
Compare
matzuk
requested changes
Oct 11, 2021
| * The timeout during which attempts will be made by the | ||
| * [com.kaspersky.kaspresso.flakysafety.ContinuouslyProviderImpl]. | ||
| */ | ||
| var timeoutMs: Long = timeoutMs |
There was a problem hiding this comment.
Штука в том, что раньше давным давно мы давали возможность пользователю менять данные параметры в уже созданном и распространенном объекте. Поэтому есть вероятность, что кому-то что-то отломаем.
There was a problem hiding this comment.
Можно оставить эти проперти, пометив их Deprecated, при этом создав нормальный конструктор.
В Deprecated написать, что переопределять Params надо так то и так то
| * The timeout during which attempts will be made by the | ||
| * [com.kaspersky.kaspresso.flakysafety.FlakySafetyProviderSimpleImpl]. | ||
| */ | ||
| var timeoutMs: Long = timeoutMs |
|
|
||
| companion object { | ||
| const val defaultTimeoutMs: Long = 10_000L | ||
| const val defaultIntervalMs: Long = 500L | ||
| val defaultAllowedExceptions: MutableSet<Class<out Throwable>> = mutableSetOf( |
There was a problem hiding this comment.
mutable коллекция значений по умолчанию в статике. Планируется, что можно будет её модифицировать для каких-то целей вне конструктора?
There was a problem hiding this comment.
плюсую, тут readable коллекция должна быть
matzuk
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.