Issue 249/compose support #307

matzuk · 2021-11-06T15:08:08Z

What remains:

autoscroll behavior interceptor for Jetpack Compose
compose (or-then) functionality for Jetpack Compose
Jetpack Compose tests on the JVM environment
Readme
Add ".idea" to VCS according to this article

… logic complicates and has flaky

…s removed

…ct2 updating

matzuk · 2021-11-06T15:09:20Z

build-conventions/android-convention/src/main/kotlin/convention.android-library.gradle.kts

-            enabled = false
-        }
-    }
+    // todo doesn't work on AGP 4.2.2


@RuslanMingaliev such api is not available now

matzuk · 2021-11-06T15:09:59Z

gradle/libs.versions.toml

@@ -1,13 +1,15 @@
 [versions]
-kotlin = "1.4.32"
+kotlin = "1.5.21"


1.5.31 causes weird problems, postponed

matzuk · 2021-11-06T15:10:51Z

build-conventions/android-convention/src/main/kotlin/convention.android-base.gradle.kts

+        }
+    }
+
+    // temp solution


@RuslanMingaliev need your help here

kaspresso/build.gradle.kts

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/autoscroll/ObjectAutoScrollProviderImpl.kt

matzuk · 2021-11-06T15:15:53Z

...resso/interceptors/behaviorkautomator/impl/flakysafety/FlakySafeObjectBehaviorInterceptor.kt

@@ -30,7 +30,10 @@ class FlakySafeObjectBehaviorInterceptor(
        interaction: UiObjectInteraction,
        assertion: UiObjectAssertion,
        activity: () -> T
-    ): T = flakySafely(action = activity)
+    ): T = flakySafely(action = {
+        interaction.reFindUiObject()


Improvements of Kautomator stability

Could you describe the problem?

This one must be relocated to a separate Interceptor. Thanks that you've highlighted.

Good question about stability. So, the concept is similar to the one that we had in Loader...Interceptor. But, the architecture solution is better and the same with Jetpack Compose Intercepting (see old weird methods like loadView and etc.). Better stability is achieved due to changing the order of behavior interceptors (try to reload earlier). I think, there were cases when SystemDialog and Scrolling Interceptors consumed all allocated time, that's why there was no time to reload Element. But, I don't have tests where I can check it.

Abstractions don't leak because BehaviorInterceptor offers access to all possible data (Interaction, Action, Assert). So, we give broad possibilities to do something with all of this. Also, I tried to reload an Element by using of custom getter where we recalculate the element. But, such a solution provides some edge cases like recalculation in absolutely all cases, possible caching of property that can lead to an inconsistent state, and others.

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/kaspresso/Kaspresso.kt

…er functionality is relocated from FlakySafety functionality to the separate classes

eakurnikov · 2021-11-09T14:36:16Z

gradle/libs.versions.toml


 [libraries]
 # plugins
 kotlinPlugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
-androidPlugin = "com.android.tools.build:gradle:4.1.0"
+androidPlugin = "com.android.tools.build:gradle:4.2.2"


Мб нам его до 7 поднять?

I tried but I got a lot of errors with our plugins =(

eakurnikov

Nnoooice

eakurnikov · 2021-11-09T14:45:30Z

...kotlin/com/kaspersky/kaspresso/interceptors/tolibrary/compose/ComposeSemanticsInterceptor.kt

+                interaction.perform(action)
+            },
+            operation = {
+                    acc, deviceBehaviorInterceptor ->


Линт внутри меня говорит, что тут форматирование поехало)0)

Will check it

eakurnikov · 2021-11-09T14:50:46Z

...main/kotlin/com/kaspersky/components/kautomator/intercept/interaction/UiObjectInteraction.kt

-     * @return true if object was found, false otherwise
-     */
-    fun tryToFindUiObject(): Boolean {
+    private fun calculateUiObject(): UiObject2? {


А почему calculate то? Она вроде не считает ничего

Yep, maybe there is a sense to put another name.

eakurnikov · 2021-11-09T14:53:07Z

...s/kaspresso-sample/src/main/kotlin/com/kaspersky/kaspressample/jetpackcompose/resources/C.kt

+package com.kaspersky.kaspressample.jetpackcompose.resources
+
+// Like R, but C
+object C {


Это твое изобретение или это паттерн типо рекомендованный? Элементы по строке ищутся?

@RuslanMingaliev suggested such an approach. I like it =)

kaspresso/build.gradle.kts

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/elementloader/ElementLoaderProviderImpl.kt

RuslanMingaliev · 2021-11-09T17:40:08Z

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/elementloader/ElementLoaderProviderImpl.kt

+            logger.i("Reloading of the element is started")
+            elementLoader.invoke()
+            logger.i("Reloading of the element is finished")
+            logger.i("Repeat action again with the reloaded element")


Too verbose logging, I think

No, it's not. Have a look at logs running examples.

RuslanMingaliev · 2021-11-09T17:41:57Z

...resso/interceptors/behaviorkautomator/impl/flakysafety/FlakySafeObjectBehaviorInterceptor.kt

@@ -30,7 +30,10 @@ class FlakySafeObjectBehaviorInterceptor(
        interaction: UiObjectInteraction,
        assertion: UiObjectAssertion,
        activity: () -> T
-    ): T = flakySafely(action = activity)
+    ): T = flakySafely(action = {
+        interaction.reFindUiObject()


Could you describe the problem?

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/kaspresso/Kaspresso.kt

RuslanMingaliev · 2021-11-10T20:22:02Z

...n/kotlin/com/kaspersky/components/kautomator/component/common/assertions/UiBaseAssertions.kt

+        // the implementation is a little bit tricky because
+        // UiObjectInteractionDelegate throws UnfoundedUiObjectException in case of absence of a related UIObject2
+        // that's why we just catch the mentioned exception and do a final check
+        val notDisplayed = try {


Why did you change the previous behavior?

The previous solution required an additional method of UiObjectInteractionDelegate which was too poor because made an abstraction leak.

...ain/kotlin/com/kaspersky/kaspressample/jetpackcompose/features/flaky/SimpleFlakyViewModel.kt

RuslanMingaliev · 2021-11-10T20:34:32Z

gradle/libs.versions.toml

 uiAutomator = "androidx.test.uiautomator:uiautomator:2.2.0"
-fragmentTesting = "androidx.fragment:fragment-testing:1.3.2"
+fragmentTesting = "androidx.fragment:fragment-testing:1.3.6"
+# upgrading to 4.6.1 is blocked by https://github.com/robolectric/robolectric/issues/6593


It's not a bug, there is a solution in the comments

I am not sure that you are right. Ok, can you try to fix it?

matzuk added 13 commits October 25, 2021 11:52

#249. Kakao Compose is included

438bd46

#249. fixed some mistakes in Robolectric wiki

0db17b6

#249. libraries update and including

ed71945

#249. main compose semantics interceptors are included to Kaspresso

56b727c

#249. Jetpack Compose Main page (template) in the sample is ready

c75259d

#249. The first test with Jetpack Compose in Kaspresso is ready

6df379b

#249. Kautomator refactoring. loadView logic was removed because this…

7211a8b

… logic complicates and has flaky

#249. Flaky defence is ready. Copy of ComposeOperations typealiases i…

2b90a5f

…s removed

#249. Improved stability of Kautomator due to changed logic of UiObje…

61a7b45

…ct2 updating

#249. Improved stability of Kautomator due to changed logic of UiObje…

7a77c87

…ct2 updating

#249. static onUiScreen method for Kamulator screens

49f1adb

#249. light changes in ComposeSimpleFlakyTest

3d7da93

#249. FailureLogging interceptors come back

a2094e1

matzuk requested review from RuslanMingaliev and eakurnikov November 6, 2021 15:08

matzuk commented Nov 6, 2021

View reviewed changes

kaspresso/build.gradle.kts Outdated Show resolved Hide resolved

matzuk commented Nov 6, 2021

View reviewed changes

kaspresso/build.gradle.kts Outdated Show resolved Hide resolved

matzuk commented Nov 6, 2021

View reviewed changes

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/autoscroll/ObjectAutoScrollProviderImpl.kt Show resolved Hide resolved

matzuk commented Nov 6, 2021

View reviewed changes

kaspresso/src/main/kotlin/com/kaspersky/kaspresso/kaspresso/Kaspresso.kt Show resolved Hide resolved

matzuk added 2 commits November 7, 2021 09:05

#249. KakaoCompose 0.0.3 is included

d08bf45

#249. Kaspresso compose is available for Jetpack Compose. ElementLoad…

e3a7a32

…er functionality is relocated from FlakySafety functionality to the separate classes

This was linked to issues Nov 7, 2021

Jetpack compose support #249

Closed

Up Kakao Version #284

Closed

Unable to identify and typeText on the UIScreen elements using UITextEdit properties #216

Closed

matzuk added 2 commits November 7, 2021 14:19

#249. Robolectric support for Jetpack Compose

0f028fa

#249. small improvements in build.gradle

068f0b0

matzuk and others added 4 commits November 7, 2021 16:55

#249. AutoScroll interceptor is ready

67860e2

#249. detekt fixes

aeb5e5a

#249. Jetpack Compose readme

7b626a1

#249 Jetpack Compose doc

c8aa36b

eakurnikov reviewed Nov 9, 2021

View reviewed changes

eakurnikov previously approved these changes Nov 9, 2021

View reviewed changes

RuslanMingaliev reviewed Nov 10, 2021

View reviewed changes

matzuk added 7 commits November 14, 2021 15:03

#249. Reverted the previous behavior of ObjectAutoScrollProviderImpl

44f3bbd

#249. Changed the order of behavior interceptors to improve stability

1165160

#249. Up Kakao-Compose lib version

dc905e6

#249. ElementLoaderParams

abf3983

#249. reFindUiObject again

2edacd0

#249. provide libs.composeUiTest as api dependency

795dd5a

#249. renaming in VM

387549a

matzuk dismissed eakurnikov’s stale review via 387549a November 14, 2021 14:07

matzuk added 2 commits November 15, 2021 08:52

#249. up Kakao-Compose library version

22aaa15

#249. readme changes

60f586d

RuslanMingaliev approved these changes Nov 15, 2021

View reviewed changes

matzuk merged commit f25f393 into master Nov 15, 2021

AzamatCherchesov deleted the issue-249/compose-support branch September 7, 2023 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 249/compose support #307

Issue 249/compose support #307

matzuk commented Nov 6, 2021 •

edited

Loading

matzuk Nov 6, 2021

matzuk Nov 6, 2021

matzuk Nov 6, 2021

matzuk Nov 6, 2021

RuslanMingaliev Nov 9, 2021

matzuk Nov 12, 2021 •

edited

Loading

eakurnikov Nov 9, 2021

matzuk Nov 12, 2021

eakurnikov left a comment

eakurnikov Nov 9, 2021

matzuk Nov 12, 2021

eakurnikov Nov 9, 2021

matzuk Nov 12, 2021

eakurnikov Nov 9, 2021

matzuk Nov 12, 2021

RuslanMingaliev Nov 9, 2021

matzuk Nov 12, 2021

RuslanMingaliev Nov 9, 2021

RuslanMingaliev Nov 10, 2021

matzuk Nov 12, 2021

RuslanMingaliev Nov 10, 2021

matzuk Nov 12, 2021

Issue 249/compose support #307

Issue 249/compose support #307

Conversation

matzuk commented Nov 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matzuk Nov 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eakurnikov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matzuk commented Nov 6, 2021 •

edited

Loading

matzuk Nov 12, 2021 •

edited

Loading