Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 315/fix kamulator tests #326

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Issue 315/fix kamulator tests #326

merged 5 commits into from
Nov 26, 2021

Conversation

matzuk
Copy link
Member

@matzuk matzuk commented Nov 23, 2021

No description provided.

@matzuk matzuk requested a review from eakurnikov as a code owner November 23, 2021 15:10
@matzuk matzuk linked an issue Nov 23, 2021 that may be closed by this pull request
Fix Kamulator tests #315
Closed
@matzuk matzuk changed the base branch from master to issue-310/compose_module November 24, 2021 04:57
RuslanMingaliev
RuslanMingaliev reviewed Nov 25, 2021
View reviewed changes
...ple/src/androidTest/java/com/kaspersky/kaspresso/kautomatorsample/screen/ComponentsScreen.kt Outdated
@@ -7,7 +7,7 @@ import com.kaspersky.components.kautomator.component.dialog.UiAlertDialog
import com.kaspersky.components.kautomator.component.text.UiButton
import com.kaspersky.components.kautomator.screen.UiScreen

object ComponentsScreen : UiScreen<ComponentsScreen>() {
class ComponentsScreen : UiScreen<ComponentsScreen>() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use 3 different ways to work with Page Objects in our tests. I prefer to use objects because it's very simple and clear. I propose you fix the problem for objects rather than using classes, especially with onUiScreen which creates a new instance on every call.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Fixed

@matzuk matzuk merged commit f60347a into issue-310/compose_module Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuslanMingaliev RuslanMingaliev RuslanMingaliev approved these changes

@eakurnikov eakurnikov Awaiting requested review from eakurnikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Kamulator tests
2 participants
@matzuk @RuslanMingaliev