Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TECH: fix system dialog provider #460

Merged
merged 2 commits into from
Dec 21, 2022
Merged

TECH: fix system dialog provider #460

merged 2 commits into from
Dec 21, 2022

Conversation

Areyana
Copy link
Collaborator

@Areyana Areyana commented Dec 21, 2022 •
edited
Loading

related to #433

@Areyana Areyana self-assigned this Dec 21, 2022
@Areyana Areyana added the bug Something isn't working label Dec 21, 2022
Nikitae57
Nikitae57 previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@Nikitae57 Nikitae57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to add tests for this case if there're no any yet

@Areyana
Copy link
Collaborator Author

Areyana commented Dec 21, 2022

Would be cool to add tests for this case if there're no any yet

Will be in #452

@Areyana Areyana requested a review from Nikitae57 December 21, 2022 14:19
@Areyana Areyana merged commit df29037 into master Dec 21, 2022
@Areyana Areyana mentioned this pull request Dec 21, 2022
Closed
@AzamatCherchesov AzamatCherchesov deleted the TECH-new-dialogs-safety branch September 7, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikitae57 Nikitae57 Nikitae57 approved these changes

@matzuk matzuk Awaiting requested review from matzuk matzuk is a code owner

@AzamatCherchesov AzamatCherchesov Awaiting requested review from AzamatCherchesov AzamatCherchesov is a code owner

@eakurnikov eakurnikov Awaiting requested review from eakurnikov eakurnikov is a code owner

@RuslanMingaliev RuslanMingaliev Awaiting requested review from RuslanMingaliev RuslanMingaliev is a code owner

Assignees

@Areyana Areyana

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Areyana @Nikitae57