ISSUE-86: use native resources in kAutomator #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikitae57
requested review from
matzuk,
AzamatCherchesov,
eakurnikov and
RuslanMingaliev
as code owners
Nikitae57
force-pushed
the
ISSUE-86-Kautomator-native-resources
branch
from
fd76af3 to
aa22ebc
Compare
ISSUE-86: use native resources in kAutomator
Nikitae57
force-pushed
the
ISSUE-86-Kautomator-native-resources
branch
from
aa22ebc to
c2456a6
Compare
matzuk
reviewed
May 13, 2023
| internal object RClassProvider { | ||
| private val classNameToClass = mutableMapOf<String, Class<*>>() | ||
|
|
||
| @Synchronized |
There was a problem hiding this comment.
why @Synchronized? all tests are going in one thread.
| import androidx.test.platform.app.InstrumentationRegistry | ||
|
|
||
| internal object KString : ResourceNameProvider() { | ||
| override val rClassName = "R\$string" |
There was a problem hiding this comment.
not sure that these identifiers are the same for all OS versions
| package com.kaspersky.components.kautomator.common.resources | ||
|
|
||
| internal object RClassProvider { | ||
| private val classNameToClass = mutableMapOf<String, Class<*>>() |
| @@ -1,9 +1,14 @@ | |||
| @file:Suppress("unused") | |||
| package com.kaspersky.components.kautomator.component.common.builders | |||
There was a problem hiding this comment.
I think it makes sense to enhance the documentation regarding the last changes
AzamatCherchesov
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #86