TECH: fix bug with locales in docloc tests #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumin93
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev and
Nikitae57
as code owners
|
|
Nikitae57
previously approved these changes
May 16, 2023
Nikitae57
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Смена локали в скриншот тестах сейчас работает некорректно, если в конструкторе DocLocScreenshotTestCase не указать changeSystemLocale = true. На разных версиях андроид воспроизводятся разные баги, где-то игнорируется первый язык (тот что передали первым параметром в конструктор) остальные устанавливаются корректно, где-то игнорируются все языки, хотя в логах отображается, что смена произошла корректно, ни в одном случае не менялся заголовок экрана. В этом мр все проблемы пофикшены, кроме смены заголовка экрана - оно работает правильно только на версии Android API 33, похоже, что баг в библиотеке гугла, им завели ишью https://issuetracker.google.com/issues/246092030